Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more accurate description of <teiCorpus> #2503

Merged
merged 4 commits into from
Jan 10, 2024
Merged

more accurate description of <teiCorpus> #2503

merged 4 commits into from
Jan 10, 2024

Conversation

sydb
Copy link
Member

@sydb sydb commented Nov 13, 2023

First crack at improving prose of CC for #2445

@sydb sydb added this to the Guidelines 4.7.0 milestone Nov 13, 2023
@sydb sydb requested a review from trishaoconnor November 13, 2023 02:30
@trishaoconnor
Copy link
Contributor

Reviewing the prose changes now. It is reading very well so far. Only thing that seems concerning is that all the GitHub checks/test seem to have failed.

<p>An extended example of one form of linguistic analysis commonly
practised in corpus linguistics is given in section <ptr target="#AILA"/>.
</p>
practised in corpus linguistics is given in section <ptr target="#AILA"/>.</p>
</div></div>
<div type="div2" xml:id="CCREC"><head>Recommendations for the Encoding of Large Corpora</head>
<p>These Guidelines include proposals for the identification and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for rewording line 1118 / 1117 "behind this catholic approach", perhaps rephrase using 'universal' or 'inclusive' instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seconded, and I'd suggest "universal"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to “universal” in 7f52ad0.

Copy link
Contributor

@trishaoconnor trishaoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated prose looks good to me. The examples are clearly explained and address the points raised in the related ticket #2445. I'm happy to approve a merge into dev. The comment above to reword line 1118/1117 is more of a suggestion.

@raffazizzi raffazizzi modified the milestones: Guidelines 4.7.0, Guidelines 4.8.0 Nov 16, 2023
@sydb sydb assigned trishaoconnor and unassigned raffazizzi Jan 10, 2024
@trishaoconnor trishaoconnor merged commit f720f14 into dev Jan 10, 2024
3 checks passed
@ebeshero ebeshero deleted the sydb_2445 branch July 6, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants