-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more accurate description of <teiCorpus>
#2503
Conversation
Reviewing the prose changes now. It is reading very well so far. Only thing that seems concerning is that all the GitHub checks/test seem to have failed. |
<p>An extended example of one form of linguistic analysis commonly | ||
practised in corpus linguistics is given in section <ptr target="#AILA"/>. | ||
</p> | ||
practised in corpus linguistics is given in section <ptr target="#AILA"/>.</p> | ||
</div></div> | ||
<div type="div2" xml:id="CCREC"><head>Recommendations for the Encoding of Large Corpora</head> | ||
<p>These Guidelines include proposals for the identification and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion for rewording line 1118 / 1117 "behind this catholic approach", perhaps rephrase using 'universal' or 'inclusive' instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconded, and I'd suggest "universal"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to “universal” in 7f52ad0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated prose looks good to me. The examples are clearly explained and address the points raised in the related ticket #2445. I'm happy to approve a merge into dev. The comment above to reword line 1118/1117 is more of a suggestion.
First crack at improving prose of CC for #2445