-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible memory leak/other system slowing issues #7
Comments
Well this is peculiar. Rust shouldn't have memory leaks as long as you don't use unsafe. I used unsafe here only once so there should be no memory leaks. Is this something you experience with every save file? Especially long ones? I run 48GB of RAM so optimising memory usage is not something I had to do and chances are the program is running fine, just requiring an obscene amount of memory. How big was the source save file? I believe this issue is just the matter of me not doing much memory optimisations |
The save file was 38MB |
On the chances the program was doing fine |
During the weekend I will try to find some free time and properly benchmark the tool. This should give me a clearer picture of the memory footprint and if this issue is save file specific or tool wide. As it stands right now I can only speculate, but I believe this is simply the case of my not optimising for memory usage. |
Having investigated memory usage using GNU Time utility I found the memory usage on my Linux machine for my 200-ish year save file to range from 2.1 GB to 1.2 GB depending on whether I used game data. The main culprit for this footprint seems to be localization. I find this most troubling, as that's not even close to the figures you are reporting. I will attempt to install a Windows VM to further investigate the issue when I find some free time. Does the memory footprint differ between save files? |
When using the history extractor it will continuously use increased amounts of memory up to about 12gb assigned considerably slowing down the device. The first time I ran it I left it going and was forced to hard restart the computer. Second time I force quit it as the computer was becoming unusable. Both times it was while rendering the history. Some files were saved - a history file containing some timelines and characters that currently takes up 1.6gb(not sure if this is normal but it feels very large) and is not complete(attempting to go home after opening timeline simply says file not found showing process was incomplete).
I've attached the save file as well as screenshots of the resource monitor
Windows 11
16gb Ram, i5- 12450H using ssd.
https://file.io/HHjFQ7sIurHv
The text was updated successfully, but these errors were encountered: