ErrorCard created #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MoisesAdame
requested changes
Apr 19, 2024
src/components/ErrorCard/types.ts
Outdated
Comment on lines
1
to
3
| export interface IErrorCard{ | ||
| title: string; | ||
| } |
There was a problem hiding this comment.
Agregar cometarios y checar que aparezcan en los storybooks. Puedes checar components/Button/types.ts.
|
|
||
| const ErrorCard: React.FC<IErrorCard> = ({ title }) => { | ||
| return ( | ||
| <div className="bg-white-500 text-red-700 text-left p-4 rounded-xl shadow-lg text-2xl font-bold"> |
There was a problem hiding this comment.
Vuelve a revisar el figma y asegúrate de seguirlo tal y como esta, por ejemplo:
- bg-white-500: Sería bg-white, porque el figma tiene #FFFFF.
- text-red-700: Sería text-aci-red que es #CC3232, ya que text-red-700 no es el que se puso en el figma.
- p-4: Se cambiaria ya que en figma tenemos 20px en padding horizontal y 5px en vertical, lo cual equivaldría aproximadamente a px-5 y py-1
- text-2xl: Mas bien seria text-text, ya que en figma tenemos Text Black Bold. font-bold se queda
There was a problem hiding this comment.
Reestructura todo el archivo basándote en components/Button/Button.stories.tsx, ya que faltan muchas etiquetas como parameters, argTypes y tags
MoisesAdame
requested changes
Apr 19, 2024
|
|
||
| const ErrorCard: React.FC<IErrorCard> = ({ title }) => { | ||
| return ( | ||
| <div className="bg-white text-aci-red text-left px-5 py-1 rounded-xl shadow-lg text-text font-bold"> |
There was a problem hiding this comment.
agregar w-full para que tome el width total del componente padre en el que lo pongamos.
| @@ -0,0 +1,26 @@ | |||
| import { Meta, StoryObj } from '@storybook/react'; | |||
| import { fn } from '@storybook/test'; | |||
There was a problem hiding this comment.
Checar si la dependencia import { fn } from '@storybook/test'; esta en uso, si no, quitarla.
MoisesAdame
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.