fix: vault env 적용

SystemConsultantGroup · Sep 1, 2024 · ba1ad84 · ba1ad84
1 parent fa61edd
commit ba1ad84
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 18 deletions.
diff --git a/.github/workflows/qa.yml b/.github/workflows/qa.yml
@@ -5,7 +5,7 @@ on:
     branches: ["qa"]
 env:
   dockerimage_tag: ${{ github.sha }}
-  dockerimage_name: harbor.k8s.scg.skku.ac.kr/library/ice-gs-thesis-be
+  dockerimage_name: jcy0308/ice-gs-thesis-be-qa
 jobs:
   build:
     runs-on: ubuntu-latest
@@ -36,21 +36,8 @@ jobs:
       - name: Docker 준비(4/4) - 레지스트리 로그인
         uses: docker/login-action@v2
         with:
-          registry: ${{ secrets.HARBOR_REGISTRY }}
-          username: ${{ secrets.HARBOR_USERNAME }}
-          password: ${{ secrets.HARBOR_PASSWORD }}
-      - name: env 파일 생성
-        run: |
-          echo APP_ENV="development" >> .env
-          echo APP_PORT="${{secrets.APP_PORT}}" >> .env
-          echo DATABASE_URL="${{secrets.DATABASE_URL_QA}}" >> .env
-          echo JWT_SECRET="${{secrets.JWT_SECRET}}" >> .env
-          echo MINIO_END_POINT="${{secrets.MINIO_END_POINT}}" >> .env
-          echo MINIO_PORT="${{secrets.MINIO_PORT}}" >> .env
-          echo MINIO_ACCESS_KEY="${{secrets.MINIO_ACCESS_KEY}}" >> .env
-          echo MINIO_SECRET_KEY="${{secrets.MINIO_SECRET_KEY}}" >> .env
-          echo MINIO_BUCKET_NAME="${{secrets.MINIO_BUCKET_NAME_QA}}" >> .env
-          cat .env
+          username: ${{ secrets.DOCKER_USERNAME }}
+          password: ${{ secrets.DOCKER_PASSWORD }}
       - name: Docker 이미지 빌드+푸시
         id: build-and-push
         uses: docker/build-push-action@v5.1.0

diff --git a/src/config/kafka/kafka.service.ts b/src/config/kafka/kafka.service.ts
@@ -22,8 +22,8 @@ export class KafkaProducer implements OnModuleInit, OnModuleDestroy {
       },
       sasl: {
         mechanism: "scram-sha-256",
-        username: "user1",
-        password: "EXQhgljABW",
+        username: process.env.SASL_USER,
+        password: process.env.SASL_PASSWORD,
       },
     });
     this.producer = this.kafka.producer();