Fix shared encode/decode not being displayed on AMD #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously "ENC/DEC" took up most of the space leaving only 2 characters for the percentage & bar.
|
Thank you! I remember it used to advertise the shared decode/encode as decode but it could have changed with a kernel version or newer GPUs … |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The UI only shows the decode usage when
encode_decode_sharedis true but amdgpu will only use the encode usage field when it is shared, causing nvtop to never show any usage. I've now made it save the usage to the decode usage field when it's shared.#352 seems related, but seemingly not solved.
I also made the ENC/DEC field longer, so that there's a proper usage bar and
100%doesn't look bad.Before:
After:
Thanks,
Steve