Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove eth custom name #313

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Fix/remove eth custom name #313

merged 6 commits into from
Jan 10, 2025

Conversation

randy75828
Copy link
Collaborator

No description provided.

sarah-thong
sarah-thong reviewed Jan 9, 2025
View reviewed changes
config.schema.json Show resolved Hide resolved
configs/mainnet.json Show resolved Hide resolved
@sarah-thong
Copy link
Collaborator

sarah-thong commented Jan 9, 2025 •
edited by randy75828
Loading

UI Comments

  • Don't forget to remove the input validation from scripts/check_configs.ts as well.
    image

@randy75828 randy75828 merged commit b78e1ea into master Jan 10, 2025
1 check passed
@randy75828 randy75828 deleted the fix/remove-eth-custom-name branch January 10, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-thong sarah-thong sarah-thong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randy75828 @sarah-thong