Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requests requirement #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wfordh
Copy link

@wfordh wfordh commented Sep 8, 2021

Updating the requests requirement to be ">=2.22.0" instead of "=2.22.0" in order to avoid urllib3 vulnerability outlined here. After changing the files, I installed the package locally and was able to successfully run the following functions:

  • user.get_user()
  • `user.get_all_leagues("nfl", 2021)
  • league.get_matchups(1)
  • league.get_users()

I did not change the package version in setup.py, but that could be folded in easily if you think it should be.

@yaleman
Copy link

yaleman commented Feb 15, 2022

@SwapnikKatkoori please merge and update the library 🙏🏻

@dtsong
Copy link

dtsong commented Feb 25, 2022

Hmm, given that there hasn't been much traffic or activity in this GitHub repo since 2019 and it is under the MIT License, would it make sense to make a fork and new home for changes? I am open to doing something like that since I think it would open so much potential for development to have a Python wrapper like this around the Sleeper API.

@dtsong
Copy link

dtsong commented Feb 25, 2022

I'll see what I can do to get some of this rolling in the coming weekend since I will have some time to get some Sleeper API related development going, definitely happy to add you guys as collaborators for the forked repo here if you wish to make PRs and whatnot:

https://github.com/dtsong/sleeper-api-wrapper

@yaleman @wfordh

Definitely happy to cross the changes over to this repo if @SwapnikKatkoori wishes this to be the home for the code, but happy to also help general development effort continue cuz I can definitely see lots of potential with this library

@wfordh
Copy link
Author

wfordh commented Mar 1, 2022

@dtsong not sure how much time I'll have to contribute, but happy to help out where possible since I'm at least a little familiar with the code from working with this original repo

@dtsong
Copy link

dtsong commented Mar 2, 2022

sounds good @wfordh, feel free to raise this pull request against my repository (https://github.com/dtsong/sleeper-api-wrapper), will definitely take a look along with possibly getting the other pull requests raised / establish all the good CICD stuff to ensure we're not introducing breaking changes and whatnot

@yaleman
Copy link

yaleman commented Mar 3, 2022

Just note that as your repo's a fork, if @SwapnikKatkoori deletes theirs, yours goes too (obviously you could recreate it from local code)

@dtsong
Copy link

dtsong commented Mar 3, 2022

Oh, good to know, thanks @yaleman. I'll make a new code repo in that case, didn't know that about repo forks.

Un-forked the repo here: https://github.com/dtsong/sleeper-api-wrapper

@SwapnikKatkoori
Copy link
Owner

@dtsong really appreciate you doing this. Will put a link to your repo in the readme to this project.

@dtsong
Copy link

dtsong commented Mar 4, 2022

No problem @SwapnikKatkoori, thank you for getting things going to begin with and looking forward to the upside that a codebase like this can bring just like the incoming NFL rookies running in the Combine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants