Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hamberger Menu Z-Index Issue and Mobile Overflow Scroll Due to Iframe Width #1116

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

rajveeerr
Copy link
Collaborator

@rajveeerr rajveeerr commented Oct 1, 2024

This pull request fixes two issues:

  1. Hamberger Menu Z-Index Issue: Adjusted the z-index of the hammer menu to prevent it from being overlapped by other elements like images on mobile devices. This ensures that the menu remains visible and functional.

  2. Mobile Body Overflow Scroll Issue: The mobile version had an overflow scroll in the x-direction due to the <iframe> element exceeding the screen width. The width of the iframe has been adjusted to fit within the viewport, preventing unnecessary scrolling.

Fixes

Screenshots

BEFORE AFTER
Screenshot 2024-10-02 at 2 22 37 AM Screenshot 2024-10-02 at 2 26 04 AM

Checklist

  • Z-index of hammer menu adjusted.
  • Overflow scroll issue on mobile due to iframe width fixed.
  • Tests have been added or updated to cover the changes.
  • Code follows the established coding style guidelines.

Copy link

vercel bot commented Oct 1, 2024

@rajveeerr is attempting to deploy a commit to the Suraj Pratap's projects Team on Vercel.

A member of the Team first needs to authorize it.

@SurajPratap10 SurajPratap10 merged commit 50f35ed into SurajPratap10:main Oct 2, 2024
3 of 5 checks passed
@rajveeerr rajveeerr added level2 and removed level1 labels Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants