fix: fixes recompute of slab and footing reinforcement

Fixes: amrit3701#213
SurajDadral · Jan 4, 2025 · eeb5b5b · eeb5b5b
1 parent 68ddd38
commit eeb5b5b
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 8 deletions.
diff --git a/FootingReinforcement/FootingReinforcement.py b/FootingReinforcement/FootingReinforcement.py
@@ -303,7 +303,6 @@ def makeFootingReinforcement(
             footingReinforcementGroup.ViewObject
         )
 
-    footingReinforcementGroup.IsMakeOrEditRequired = False
     footingReinforcementGroup.MeshCoverAlong = mesh_cover_along
     footingReinforcementGroup.Facename = facename
     footingReinforcementGroup.Structure = structure
@@ -699,7 +698,6 @@ def editFootingReinforcement(
         column_sec_hook_extension arguments is a tuple.
     Syntax: (<value_for_sec_xdir_rebars>, <value_for_sec_ydir_rebars>).
     """
-    footingReinforcementGroup.IsMakeOrEditRequired = False
     footingReinforcementGroup.MeshCoverAlong = mesh_cover_along
     if facename:
         footingReinforcementGroup.Facename = facename

diff --git a/FootingReinforcement/FootingReinforcementObject.py b/FootingReinforcement/FootingReinforcementObject.py
@@ -942,14 +942,12 @@ def onChanged(self, obj, prop):
         if prop != "IsMakeOrEditRequired" and obj.IsMakeOrEditRequired:
             obj.IsMakeOrEditRequired = False
             self.makeOrEditFootingReinforcement(obj)
-            obj.IsMakeOrEditRequired = True
 
     def execute(self, obj):
         pass
 
     def makeOrEditFootingReinforcement(self, obj):
         """Create or update Footing Reinforcement"""
-        obj.IsMakeOrEditRequired = False
         mesh_cover_along = obj.MeshCoverAlong
         facename = obj.Facename
         structure = obj.Structure
@@ -1549,7 +1547,6 @@ def makeOrEditFootingReinforcement(self, obj):
 
         self.addColumnsGroups(obj.ReinforcementGroups[1], columns_container)
         FreeCAD.ActiveDocument.recompute()
-        obj.IsMakeOrEditRequired = True
 
     def removeColumnReinforcement(self, column):
         """Remove column reinforcement from footing"""
@@ -1573,7 +1570,6 @@ def removeColumnReinforcement(self, column):
 
     def removeSlabReinforcement(self, slab):
         """Remove slab reinforcement from footing"""
-        slab.IsMakeOrEditRequired = False
         for rebar in slab.Group:
             base_name = rebar.Base.Name
             FreeCAD.ActiveDocument.removeObject(rebar.Name)

diff --git a/SlabReinforcement/SlabReinforcement.py b/SlabReinforcement/SlabReinforcement.py
@@ -493,7 +493,6 @@ def editSlabReinforcement(
         Default is None
     """
     # Update value of SlabReinforcementGroup
-    slabReinforcementGroup.IsMakeOrEditRequired = False
     slabReinforcementGroup.MeshCoverAlong = mesh_cover_along
 
     if structure:
@@ -600,4 +599,5 @@ def editSlabReinforcement(
             slabReinforcementGroup.CrossDistributionRebarsSpacing = (
                 cross_distribution_rebars_amount_spacing_value
             )
+    FreeCAD.ActiveDocument.recompute()
     return slabReinforcementGroup
diff --git a/SlabReinforcement/SlabReinforcementObject.py b/SlabReinforcement/SlabReinforcementObject.py
@@ -773,7 +773,6 @@ def onChanged(self, obj, prop):
         if prop != "IsMakeOrEditRequired" and obj.IsMakeOrEditRequired:
             obj.IsMakeOrEditRequired = False
             self.makeOrEditSlabReinforcement(obj)
-            obj.IsMakeOrEditRequired = True
 
     def execute(self, obj):
         pass