Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'seq-logging' needs to be updated. #3

Open
bard83 opened this issue Feb 27, 2020 · 14 comments
Open

'seq-logging' needs to be updated. #3

bard83 opened this issue Feb 27, 2020 · 14 comments

Comments

@bard83
Copy link

bard83 commented Feb 27, 2020

I get the following exception when I try to send events to Seq:

TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:"
    at new ClientRequest (_http_client.js:143:11)
    at Object.request (http.js:44:10)
    at /app/node_modules/seq-logging/seq_logger.js:222:28
    at new Promise (<anonymous>)
    at SeqLogger._post (/app/node_modules/seq-logging/seq_logger.js:205:16)
    at SeqLogger._sendBatch (/app/node_modules/seq-logging/seq_logger.js:169:21)
    at /app/node_modules/seq-logging/seq_logger.js:152:29 {
  code: 'ERR_INVALID_PROTOCOL'
}```

This is solved in the latest version of `seq-logging`, could you please update your dependencies?

@bard83
Copy link
Author

bard83 commented Feb 27, 2020

A pull request is already opened. It would be great to to approve it.

@Apollon77
Copy link

Yes, that would be awesome @SuperPaintman do you think you can do an update here?

@nblumhardt
Copy link

Hello! We're the company that develops Seq, and we'd be open to taking on maintainership of this package, if that would be helpful @SuperPaintman ? If so, please let me know how we should reach out to coordinate 🙂

@Apollon77
Copy link

@nblumhardt FYI ... https://github.com/RubenBez/winston-seq is an updated fork which is winston 3 compatible already and ublished on npmjs temporary as https://www.npmjs.com/package/winston-seq-updated ... that would be the ideal "base"I think ... but yes having the originalpackage update would be awesome

@nblumhardt
Copy link

Thanks for the note @Apollon77 - yes, we'd be keen to help integrate the current changes from forks, if we're able to get them back into the "obviously-named" package 👍

@richard-swyftx-zz
Copy link

richard-swyftx-zz commented Jun 23, 2021

@nblumhardt This repo hasn't been touched in over 4 years - I'm guessing its dead.
How about datalust create its own repo and npm package with a different name: seq-winston or winston3-seq or ....
It would make sense for Datalust to own both the repo and npm package

@Apollon77
Copy link

We use https://www.npmjs.com/package/winston-seq-updated from @RubenBez as intermediate solution

@richard-swyftx-zz
Copy link

@Apollon77 I tried that package, but the log templates do not automatically get updated on Seq, so I reverted.
I'm hoping Datalust (@nblumhardt ) create a new package in the near future.

@nblumhardt - Would you be open to take control of a new repo for seq-winston if I were to develop it myself? Or will you guys be doing this in the near future?

@nblumhardt
Copy link

@richard-swyftx thanks for the explanation and offer of help! 👍

Yes, we'd be open to maintaining a package. Now that NPM supports organizations/namespaces, we could publish this as @datalust/winston-seq?

I can create a (blank) datalust/winston-seq GitHub repository, we can pull together the various bits and pieces over there, and once we're happy that it's working smoothly, publish under the name above. What do you think?

@Apollon77
Copy link

If original developer is inactive you can also contact npm to get ownership of the "unscoped" package ... needs 2-3 weeks but works in general ... so also an option to think about (in parallel).

I would love to get an official package also for use in our projects, so great!
If the "old" module is a good basis then the @RubenBez verison is an updated one maybe as basis ... or start from scratch :-)

@rj-xy
Copy link

rj-xy commented Jun 24, 2021

@nblumhardt sounds like a good idea, can you grant access to this account please.

@nblumhardt
Copy link

I've created https://github.com/datalust/winston-seq - I gave this some thought, we might be better off making this a fresh/clean implementation, using the seq-logging package for the heavy lifting (it doesn't look like very much Winston-specific code is needed).

I'm not sure all the features supported by the existing impls are needed, now, either - Seq does a much better job at handling arbitrary level names than it once did, and so we can probably skip level mapping, for instance.

To continue the discussion on how to get started, and to coordinate, let's move discussion to this issue over there: datalust/winston-seq#1 :-)

@mehyaa
Copy link

mehyaa commented Aug 26, 2021

For winston@3 you can use https://www.npmjs.com/package/@valuabletouch/winston-seq

@liammclennan
Copy link

Hello everyone!
https://github.com/datalust/winston-seq has been updated and published on npm as @datalust/winston-seq. Please try it out and send through your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants