Multiple artists - part two (1h)

[g105b]

A recap of what was added the other day:

• An Artist class was introduced
• An Upload had understanding of whether or not it contained more than one artist
• Bandcamp statements are now parsed correctly

What still needs to be done:

• A Statement needs to look at all the Uploads it contains to understand whether the entire statement of account is for one artist or multiple
• If a Statement represents multiple Artists, the HTML table needs to be changed out to one that groups by artist
• Each grouped artist needs to display the artist's total earnings

I think the way that I want to achieve this extra HTML is by updating the current HTML to always show the artist grouping, and hide the artist name if there's only one artist. That way, we don't have to manage two different table views.

To keep things simple, I'll create a new class ArtistAggregation to surround the Aggregation class. After the tests pass, it'll be worth refactoring things knowing what we know now... but with the tests passing this will be so much more pleasant than stabbing around in the dark.

[g105b]

I've just added a few tests to flesh out the artist usage aggregation: 72dae21

[g105b]

Uploading your real Bandcamp statement shows the following breakdown. First screenshot is the summarised artists, second screenshot is opening one table.

[g105b]

It looks to be working nicely, but I've broken the existing Behat tests, because the page structure is completely different now, even for single artists.

Before I finish this development session, I'm going to revisit the functionality where only one artist is detected, then hide the artist name, and automatically open the table view (then fix the broken tests).

[g105b]

Here's the CSV used (a fake Bandcamp file):

date	paid to	item type	item name	artist	currency	item price	quantity	discount code	sub total	transaction fee	fee type	item total	amount you received	bandcamp transaction id	paypal transaction id	net amount
11/24/22 11:45am	me@example.com	track	BC 4	Person 2	GBP	4.99	1		4.99	0.5	paypal	4.99	4.49			4.2
11/25/22 5:45pm	you@example.com	track	BC 1	Person 1	GBP	7.99	1		7.99	0.57	paypal	7.99	7.42	1234000001	3KJ69516S2466193S	6.22
12/2/22 7:56am	you@example.com	track	BC 1	Person 1	GBP	5	1		5	0.47	paypal	5	4.53	1234000002	29966046F7946584H	3.78
12/2/22 2:00pm	collected to cover your revenue share balance	track	BC 1	Person 1	GBP	1	1		1	0.5		1	0	1234000003	<-- collected to cover your revenue share balance	0.85
12/3/22 10:25am	you@example.com	track	BC 2	Person 1	GBP	2	1		2	0.27	paypal	2	1.73	1234000004	36F06739NU791841K	1.43
12/4/22 10:00am	me@example.com	track	BC 4	Person 2	GBP	3	1		3	0.5	paypal	3	2.5			2.3
12/5/22 12:51pm	you@example.com	track	BC 2	Person 1	GBP	1	1		1	0.24	paypal	1	0.76	1234000005	49H01364DL948121E	0.61
12/7/22 7:25pm	Bandcamp	track	BC 2	Person 1	GBP	0.4	1		0.4	0.1		0.4	0	1234000006		0.34
12/9/22 11:45am	me@example.com	track	BC 5	Person 2	GBP	3.5	1		3.5	0.5	paypal	3.5	3			2.78
12/10/22 8:12am	you@example.com	track	BC 3	Person 1	GBP	5	1		5	0.37	paypal	5	4.63	1234000007	3AL22901JK7712703	3.88
12/20/22 1:05pm	me@example.com	track	BC 4	Person 2	GBP	2.99	1		2.99	0.5	paypal	2.99	2.49			2.01
2/1/23 3:12pm	Bandcamp	track	BC 3	Person 1	GBP	0.78	1		0.78	0.09	paypal	0.78	0	1234000008		0.57
2/2/23 4:00pm	me@example.com	track	BC 5	Person 2	GBP	5.99	1		5.99	0.5	paypal	5.99	5.49			4.99

Here's the new Behat test that's now passing with the above file:

Feature: App should aggregate multiple artists
	In order to view earnings for multiple artists
	As a label user
	I should be able to upload statements containing multiple artists

	Scenario: I upload a Bandcamp statement containing multiple artists
		Given I am on the homepage
		When I attach the file "bandcamp-simple-multiple-artist.csv" to "statement"
		And I press "Upload"

		Then I should see 2 artists
		And I should see the total earnings for "Person 1" as "£17.68"
		And I should see the total earnings for "Person 2" as "£16.28"
		And I should see the following table data for "Person 1":
			| Work title | Amount |
			| BC 1       | £10.85 |
			| BC 3       |  £4.45 |
			| BC 2       |  £2.38 |

		And I should see the following table data for "Person 2":
			| Work title | Amount |
			| BC 4       | £8.51  |
			| BC 5       | £7.77  |

This functionality was just pushed and will deploy automatically to https://multiple-artists.dev.trackshift.app/

Please take a look at the above fake CSV and compare it to my expectations in the Behat script, to double check it adds up to what you expect (and play around in the app yourself too!)

Have fun and speak soon!