Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ [STMT-146] 소셜 로그인시 전달한 JWT 토큰의 서명이 유효하지 않은 경우에 대한 핸들링 추가 #93

Merged
merged 4 commits into from
Mar 12, 2024
Merged

✅ [STMT-146] 소셜 로그인시 전달한 JWT 토큰의 서명이 유효하지 않은 경우에 대한 핸들링 추가 #93

merged 4 commits into from
Mar 12, 2024

Conversation

zxcv9203
Copy link
Collaborator

💁 해결 하려는 문제를 적어주세요

  • 소셜 로그인시 JWT 토큰의 시그니처가 유효하지 않은 경우에 대한 메시지 핸들링 추가

🤔 어떤 방식으로 해결했는지 적어주세요

  • 기존 로직의 경우 Spring Security의 AuthenticationException을 이용하지 않아 정상적으로 핸들링이 되지 않는 문제가 존재하여 AuthenticationException을 상속하는 CustomException을 추가

@zxcv9203 zxcv9203 requested a review from 05AM as a code owner March 10, 2024 10:58
@zxcv9203 zxcv9203 added the D-1 1일 전 까지 리뷰해주세요 label Mar 10, 2024
@github-actions github-actions bot added D-0 바로 리뷰가 필요해요 and removed D-1 1일 전 까지 리뷰해주세요 labels Mar 10, 2024
05AM
05AM approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@05AM 05AM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예외 처리 세분화하신 것 좋습니다! 👍

@zxcv9203 zxcv9203 merged commit 547f203 into dev Mar 12, 2024
1 check passed
@zxcv9203 zxcv9203 deleted the STMT-146-Server-refactor-auth-exception-handling branch March 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@05AM 05AM 05AM approved these changes

Assignees
No one assigned
Labels
D-0 바로 리뷰가 필요해요
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zxcv9203 @05AM