Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ [STMT-6] fork repository๋ฅผ ์œ„ํ•œ CI workflow ๊ตฌ์ถ• - ์—๋Ÿฌ ํ•ด๊ฒฐ #79

Merged
merged 13 commits into from
Mar 5, 2024

Conversation

05AM
Copy link
Collaborator

@05AM 05AM commented Mar 5, 2024

๐Ÿ’ ํ•ด๊ฒฐ ํ•˜๋ ค๋Š” ๋ฌธ์ œ๋ฅผ ์ ์–ด์ฃผ์„ธ์š”

  • fork repository๋Š” CI ์›Œํฌํ”Œ๋กœ์šฐ ์‹คํ–‰ ์‹œ์— origin repository์˜ private github action secret์„ ์ฝ์–ด์˜ค์ง€ ๋ชปํ•จ
  • (์ถ”๊ฐ€) ๊ธฐ์กด์˜ ๋ฐฉ์‹์—๋Š” on ํŠธ๋ฆฌ๊ฑฐ์— main์— pushํ•  ๊ฒฝ์šฐ์™€ workflow_run์˜ ๊ฒฝ์šฐ๊ฐ€ ๊ฐ™์ด ์žˆ์—ˆ๋Š”๋ฐ, workflow_run ํŠธ๋ฆฌ๊ฑฐ๊ฐ€ ์ธ์‹๋˜์ง€ ์•Š์•„ CI ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ์‹คํ–‰๋˜์ง€ ์•Š์Œ

๐Ÿค” ์–ด๋–ค ๋ฐฉ์‹์œผ๋กœ ํ•ด๊ฒฐํ–ˆ๋Š”์ง€ ์ ์–ด์ฃผ์„ธ์š”

  • dev์— PR์„ ์˜ฌ๋ฆฌ๋ฉด CI trigger ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ์‹คํ–‰๋˜๊ณ , CI trigger ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ์‹คํ–‰๋˜๋ฉด CI ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ์‹คํ–‰๋˜๋„๋ก ์ˆ˜์ •
  • origin repository๊ฐ€ ์‹คํ–‰ํ•˜๋Š” ์›Œํฌํ”Œ๋กœ์šฐ์ด๋ฏ€๋กœ secret ์‚ฌ์šฉ ๊ฐ€๋Šฅ
  • CI ์›Œํฌํ”Œ๋กœ์šฐ์˜ on ํŠธ๋ฆฌ๊ฑฐ๋ฅผ workflow_run ํ•˜๋‚˜๋งŒ ์„ค์ •ํ•˜๊ณ  CI trigger ์›Œํฌํ”Œ๋กœ์šฐ๋ฅผ ๊ฐ๊ฐ dev, main์— PR์„ ์˜ฌ๋ ธ์„ ๋•Œ ์‹คํ–‰ํ•˜๋„๋ก ์ˆ˜์ •

๐Ÿง‘โ€๐Ÿซ ์ดํ•ด๋ฅผ ์œ„ํ•ด ํ•„์š”ํ•œ ์ž๋ฃŒ๊ฐ€ ์žˆ๋‹ค๋ฉด ์ฒจ๋ถ€ํ•ด์ฃผ์„ธ์š”

  • ์ฐธ๊ณ  ์ž๋ฃŒ
    https://securitylab.github.com/research/github-actions-preventing-pwn-requests/
    https://stackoverflow.com/questions/67247752/how-to-use-secret-in-pull-request-review-similar-to-pull-request-target
    https://docs.github.com/ko/actions/using-workflows/events-that-trigger-workflows#workflow_run
    • ์ด ์ด๋ฒคํŠธ๋Š” ์›Œํฌํ”Œ๋กœ ์‹คํ–‰์„ ์š”์ฒญํ•˜๊ฑฐ๋‚˜ ์™„๋ฃŒํ•  ๋•Œ ๋ฐœ์ƒํ•ฉ๋‹ˆ๋‹ค. ์ด๋ฅผ ํ†ตํ•ด ๋‹ค๋ฅธ ์›Œํฌํ”Œ๋กœ์˜ ์‹คํ–‰ ๋˜๋Š” ์™„๋ฃŒ์— ๋”ฐ๋ผ ์›Œํฌํ”Œ๋กœ๋ฅผ ์‹คํ–‰ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. workflow_run ์ด๋ฒคํŠธ์— ์˜ํ•ด ์‹œ์ž‘๋œ ์›Œํฌํ”Œ๋กœ๋Š” ์ด์ „ ์›Œํฌํ”Œ๋กœ๋Š” ๊ทธ๋ ‡์ง€ ์•Š๋”๋ผ๋„ ๋น„๋ฐ€์— ์•ก์„ธ์Šคํ•˜๊ณ  ํ† ํฐ์„ ์“ธ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ์ด๋Š” ์ด์ „ ์›Œํฌํ”Œ๋กœ๊ฐ€ ์˜๋„์ ์œผ๋กœ ๊ถŒํ•œ์ด ์—†์ง€๋งŒ ์ดํ›„ ์›Œํฌํ”Œ๋กœ์—์„œ ๊ถŒํ•œ ์žˆ๋Š” ์ž‘์—…์„ ์ˆ˜ํ–‰ํ•ด์•ผ ํ•˜๋Š” ๊ฒฝ์šฐ์— ์œ ์šฉํ•ฉ๋‹ˆ๋‹ค.

โš ๏ธ ์ฝ์–ด์ฃผ์„ธ์š”!

  • trigger ์›Œํฌํ”Œ๋กœ์šฐ๋ฅผ ํ†ต๊ณผํ–ˆ๋‹ค๊ณ  ํ•ด์„œ CI๊ฐ€ ์„ฑ๊ณตํ–ˆ๋‹ค๋Š” ๊ฒƒ์€ ์•„๋‹™๋‹ˆ๋‹ค. Action์—์„œ CI๊ฐ€ ์„ฑ๊ณตํ–ˆ๋Š”์ง€ ํ™•์ธ์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค.
  • ์ถ”ํ›„ ๋‘ ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ๋ชจ๋‘ ์„ฑ๊ณตํ•ด์•ผ์ง€ mergeํ•  ์ˆ˜ ์žˆ๋Š” ๋ฐฉ๋ฒ•์„ ์ฐพ์•„๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค.
  • main์— ์›Œํฌํ”Œ๋กœ์šฐ ํŒŒ์ผ์ด ๋ฐ˜์˜๋˜์–ด์•ผ์ง€ ํ™•์‹คํžˆ ํ…Œ์ŠคํŠธ ๊ฐ€๋Šฅํ•  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@05AM 05AM added the D-1 1์ผ ์ „ ๊นŒ์ง€ ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š” label Mar 5, 2024
@05AM 05AM self-assigned this Mar 5, 2024
@05AM 05AM requested a review from zxcv9203 as a code owner March 5, 2024 05:51
@zxcv9203
Copy link
Collaborator

zxcv9203 commented Mar 5, 2024

workflow ์‹คํ–‰ ๋ชฉ๋ก์„ ๋ณด๋Š”๋ฐ ๋ณด์ด์ง€๊ฐ€ ์•Š์•„์„œ ํ˜น์‹œ ์–ด๋””์„œ ๋Œ์•„๊ฐ„๊ฑด์ง€ ํ™•์ธ๊ฐ€๋Šฅํ•˜์‹ ๊ฐ€์š”?

@05AM
Copy link
Collaborator Author

05AM commented Mar 5, 2024

workflow ์‹คํ–‰ ๋ชฉ๋ก์„ ๋ณด๋Š”๋ฐ ๋ณด์ด์ง€๊ฐ€ ์•Š์•„์„œ ํ˜น์‹œ ์–ด๋””์„œ ๋Œ์•„๊ฐ„๊ฑด์ง€ ํ™•์ธ๊ฐ€๋Šฅํ•˜์‹ ๊ฐ€์š”?

์Œ ํ™•์ธํ•˜๊ณ  ์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ ๊ฐ™์€ ์ด๋ฆ„์œผ๋กœ 2๊ฐœ๊ฐ€ ๋˜์„œ ์‚ญ์ œํ–ˆ๋Š”๋ฐ ํ—ท๊ฐˆ๋ฆฌ๋„ค์š”!

์›Œํฌํ”Œ๋กœ์šฐ๊ฐ€ main์— ์ค‘๋ณต์œผ๋กœ ์ •์˜๋˜์–ด ์žˆ์–ด์„œ main์— mergeํ•˜์—ฌ ํ…Œ์ŠคํŠธํ•ด๋ณด๋Š”๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

@05AM 05AM merged commit 38086bf into main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-1 1์ผ ์ „ ๊นŒ์ง€ ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants