Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call otp_login on registering passkey #51

Open
AlmerCarbonEquity opened this issue Jan 7, 2025 · 1 comment · May be fixed by #57
Open

call otp_login on registering passkey #51

AlmerCarbonEquity opened this issue Jan 7, 2025 · 1 comment · May be fixed by #57
Labels
enhancement New feature or request

Comments

@AlmerCarbonEquity
Copy link
Contributor

AlmerCarbonEquity commented Jan 7, 2025

I believe otp_login should be called when a passkey is added so that the user is thereafter authenticated with 2fa, just like how it is called on login. This is also how other packages like django-two-factor-auth do it. Otherwise we have to wait for a user to logout and then login again (with their passkey!) before they can see certain content.

@AlmerCarbonEquity AlmerCarbonEquity changed the title call otp_login on setup call otp_login on registering passkey Jan 7, 2025
@Stormheg
Copy link
Member

Stormheg commented Feb 7, 2025

I'm sure I had some reason not to initially, but I can't recall my reason anymore. It's probably not an important reason, given many other packages do.

Feel free to open a pull request with this change 👍

@Stormheg Stormheg added the enhancement New feature or request label Feb 7, 2025
@AlmerCarbonEquity AlmerCarbonEquity linked a pull request Feb 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants