Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify signature UIImage export #66

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

philippzagar
Copy link
Member

@philippzagar philippzagar commented Jan 30, 2025

Simplify signature UIImage export

♻️ Current situation & Problem

The current signature export logic manually reads all strokes from the drawing and sets them to black before converting to an UI image. This can be done simpler via .withRenderingMode(.alwaysTemplate).withTintColor(.black)

⚙️ Release Notes

  • Simplify signature UIImage export
  • Fixed LFS consent document files in unit tests

📚 Documentation

Updated doc

✅ Testing

Tested locally

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@philippzagar philippzagar added the enhancement New feature or request label Jan 30, 2025
@philippzagar philippzagar self-assigned this Jan 30, 2025
@philippzagar philippzagar enabled auto-merge (squash) January 30, 2025 18:00
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.56%. Comparing base (a7cc789) to head (d5b1653).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   73.80%   73.56%   -0.23%     
==========================================
  Files          24       24              
  Lines        1328     1316      -12     
==========================================
- Hits          980      968      -12     
  Misses        348      348              
Files with missing lines Coverage Δ
...arding/Consent/Export/ConsentDocument+Export.swift 74.08% <100.00%> (-8.42%) ⬇️
...t/ConsentDocumentExportRepresentation+Render.swift 99.11% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7cc789...d5b1653. Read the comment docs.

@philippzagar philippzagar merged commit c06991b into main Jan 30, 2025
16 checks passed
@philippzagar philippzagar deleted the feat/simplify-signature-export branch January 30, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants