Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, Swift 6, Consent Contraint and SignatureView improvements #60

Merged
merged 26 commits into from
Jan 29, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
0dcd044
Allow to use SignatureView manually
Supereg Oct 23, 2024
82299b6
Merge branch 'main' into feature/signature-view-access
philippzagar Jan 22, 2025
2d2fd61
String-based name components
philippzagar Jan 22, 2025
57ce8bc
Signature date
philippzagar Jan 22, 2025
73f34f4
Refactorings to Preview
philippzagar Jan 22, 2025
c150498
Fix export of date below signature
philippzagar Jan 22, 2025
8fd56a2
Allow to use SignatureView manually
Supereg Oct 23, 2024
bb74e07
String-based name components
philippzagar Jan 22, 2025
a6dfc2c
Signature date
philippzagar Jan 22, 2025
eab5689
Refactorings to Preview
philippzagar Jan 22, 2025
9b6e6ec
Some general improvements
philippzagar Jan 22, 2025
a0c47fc
Merge remote-tracking branch 'origin/feature/signature-view-access' i…
philippzagar Jan 22, 2025
2888134
.
philippzagar Jan 22, 2025
c619a07
doc update
philippzagar Jan 22, 2025
06edcf3
test fix
philippzagar Jan 22, 2025
ded0a33
Lots of cleanup
philippzagar Jan 23, 2025
188debf
More cleanup
philippzagar Jan 24, 2025
ce44c56
More cleanup
philippzagar Jan 24, 2025
4f6f7b5
linter
philippzagar Jan 24, 2025
ef0827f
Make tests more robust
philippzagar Jan 24, 2025
97c933d
Remove OnboardingDataSource and ConsentContraint.
philippzagar Jan 25, 2025
8f662fb
linter
philippzagar Jan 25, 2025
aa24e2f
linter
philippzagar Jan 25, 2025
8ea59c9
Fix undo manager
philippzagar Jan 26, 2025
5a4ebae
Fix undomanager, further state handelling improvements and fixes
philippzagar Jan 26, 2025
bfb2528
Final improvements
philippzagar Jan 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/SpeziOnboarding/SignatureView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
#else
@Binding private var signature: String
#endif
private let name: PersonNameComponents
private let name: PersonNameComponents // TODO: allow to just specify a string! additional initializer for name components!

Check failure on line 38 in Sources/SpeziOnboarding/SignatureView.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint / SwiftLint

Todo Violation: TODOs should be resolved (allow to just specify a string...) (todo)
private let lineOffset: CGFloat


Expand Down Expand Up @@ -107,7 +107,7 @@
/// - canvasSize: The size of the canvas as a Binding.
/// - name: The name that is displayed under the signature line.
/// - lineOffset: Defines the distance of the signature line from the bottom of the view. The default value is 30.
init(
public init(
signature: Binding<PKDrawing> = .constant(PKDrawing()),
isSigning: Binding<Bool> = .constant(false),
canvasSize: Binding<CGSize> = .constant(.zero),
Expand All @@ -126,7 +126,7 @@
/// - signature: A `Binding` containing the current text-based signature as a `String`.
/// - name: The name that is displayed under the signature line.
/// - lineOffset: Defines the distance of the signature line from the bottom of the view. The default value is 30.
init(
public init(
signature: Binding<String> = .constant(String()),
name: PersonNameComponents = PersonNameComponents(),
lineOffset: CGFloat = 30
Expand Down
2 changes: 2 additions & 0 deletions Sources/SpeziOnboarding/SignatureViewBackground.swift
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
struct SignatureViewBackground: View {
private let name: PersonNameComponents
private let lineOffset: CGFloat
// TODO: add ability to show date!

Check failure on line 16 in Sources/SpeziOnboarding/SignatureViewBackground.swift

View workflow job for this annotation

GitHub Actions / SwiftLint / SwiftLint / SwiftLint

Todo Violation: TODOs should be resolved (add ability to show date!) (todo)

#if !os(macOS)
private let backgroundColor: UIColor
#else
Expand Down
Loading