Skip to content

Commit

Permalink
Be less restrictive about the chosen swiftlint version (#56)
Browse files Browse the repository at this point in the history
# Be less restrictive about the chosen swiftlint version

## ♻️ Current situation & Problem
This PR loosens the restrictions on the swiftlint version.


## ⚙️ Release Notes 
* Allow upToNextMajor swiftlint versions.
* Fixed a small concurrency issue.


## 📚 Documentation
--


## ✅ Testing
--

## 📝 Code of Conduct & Contributing Guidelines 

By submitting creating this pull request, you agree to follow our [Code
of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md):
- [x] I agree to follow the [Code of
Conduct](https://github.com/StanfordSpezi/.github/blob/main/CODE_OF_CONDUCT.md)
and [Contributing
Guidelines](https://github.com/StanfordSpezi/.github/blob/main/CONTRIBUTING.md).
  • Loading branch information
Supereg authored Aug 29, 2024
1 parent 7bd4de2 commit a3d7bc1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func swiftLintPlugin() -> [Target.PluginUsage] {

func swiftLintPackage() -> [PackageDescription.Package.Dependency] {
if ProcessInfo.processInfo.environment["SPEZI_DEVELOPMENT_SWIFTLINT"] != nil {
[.package(url: "https://github.com/realm/SwiftLint.git", .upToNextMinor(from: "0.55.1"))]
[.package(url: "https://github.com/realm/SwiftLint.git", from: "0.55.1")]
} else {
[]
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/SpeziOnboarding/ConsentView/ConsentDocument.swift
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public struct ConsentDocument: View {
}
}

private var signatureView: some View {
@MainActor private var signatureView: some View {
Group {
#if !os(macOS)
SignatureView(signature: $signature, isSigning: $viewState.signing, canvasSize: $signatureSize, name: name)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import SwiftUI
/// Extension to SwiftUI `Binding`'s enabling easy access to individual states of the ``ConsentViewState``
extension Binding where Value == ConsentViewState {
/// Access to a `Binding` of the ``ConsentViewState/base(_:)`` view state
var base: Binding<SpeziViews.ViewState> {
@MainActor var base: Binding<SpeziViews.ViewState> {
.init(
get: {
if case let .base(value) = self.wrappedValue {
Expand All @@ -30,7 +30,7 @@ extension Binding where Value == ConsentViewState {
}

/// Access to a `Binding` of the ``ConsentViewState/signing`` view state
var signing: Binding<Bool> {
@MainActor var signing: Binding<Bool> {
.init(
get: {
if case .signing = self.wrappedValue {
Expand Down

0 comments on commit a3d7bc1

Please sign in to comment.