Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeartBeat Baseline for Questionnaire Implementation #181

Merged
merged 8 commits into from
Feb 15, 2025

Conversation

pauljohanneskraft
Copy link
Contributor

HeartBeat Baseline for Questionnaire Implementation

♻️ Current situation & Problem

This PR adds basic app functionality to access Firebase Authentication and the CHOIR API.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.15%. Comparing base (aa7338f) to head (7d0f3d3).
Report is 8 commits behind head on task/heartbeat-app.

❗ There is a different number of reports uploaded between BASE (aa7338f) and HEAD (7d0f3d3). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (aa7338f) HEAD (7d0f3d3)
uitests 4 0
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             task/heartbeat-app     #181      +/-   ##
========================================================
- Coverage                 40.79%   33.15%   -7.64%     
+ Complexity                  865      771      -94     
========================================================
  Files                       301      277      -24     
  Lines                     11454    11338     -116     
  Branches                   1724     1817      +93     
========================================================
- Hits                       4672     3758     -914     
- Misses                     6319     7337    +1018     
+ Partials                    463      243     -220     
Flag Coverage Δ
uitests ?
unittests 33.15% <ø> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../bottomsheet/AddBloodPressureBottomSheetUiState.kt 93.55% <ø> (ø)

... and 88 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7338f...7d0f3d3. Read the comment docs.

@eldcn eldcn merged commit 7d0f3d3 into task/heartbeat-app Feb 15, 2025
6 of 11 checks passed
@eldcn eldcn deleted the task/heartbeat-app-update branch February 15, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants