feat: add an FAQ #360
feat: add an FAQ #360
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
astorije
force-pushed
the
astorije/faq
branch
from
8dc43e0 to
da6c9be
Compare
Try me, bot! |
| @@ -70,7 +70,7 @@ export const dot = style({ | |||
| borderRadius: "100%", | |||
| display: "inline-block", | |||
| height: "0.85rem", | |||
| margin: "0 1.5rem 1rem", | |||
| margin: "0 1rem 1rem", | |||
There was a problem hiding this comment.
[Praise] Yes the inconsistency of vertical margin/padding was bugging me...
There was a problem hiding this comment.
It was more to make the 1-line nav concise, it looked weird all stretched out.
| <InternalAnchor reloadDocument to="/events" variant="heavy"> | ||
| Previous Events | ||
| Events |
There was a problem hiding this comment.
[Praise] +1, I think it makes sense to trim this down.
| map of all parking meters, lots, and garages | ||
| </ExternalAnchor> | ||
| . Neat! | ||
| </Aside> |
| <InternalAnchor reloadDocument to="/code-of-conduct" variant="heavy"> | ||
| Code of Conduct | ||
| </InternalAnchor> | ||
| </div> |
There was a problem hiding this comment.
[Request] I think we should leave the code of conduct on the main nav. I know a lot of people who definitively feel less comfortable going to events without one linked on at least the homepage, if not every page. And I've anecdotally heard of folks using "it was hard to find!" as an excuse for misbehaving. Granted, we always announce it in opening announcements and can put it on a table display - but there's time before that when people can "miss" it.
There was a problem hiding this comment.
Mmh, ok. I don't like the nav split onto 2 lines but oh well. Re-added. Let me know what you think.
There was a problem hiding this comment.
I also don't like the nav split onto 2 lines 😂... maybe there's a compromise we could get to? Shrinking the text to something like CoC or Rules?
There was a problem hiding this comment.
I don't think either are desirable: "CoC" is not a very widespread acronym among the gen pop and "Rules" is not very representative, especially if the initial argument was that the code of conduct is hard to find.
Besides, I don't think the spacing makes sense:
I fixed the CSS to support 2 lines a little better so it's fine as is IMO. If 1 line is the priority, then I think the link to the code of conduct needs to go.
There was a problem hiding this comment.
Makes sense. In that case I defer to you :) whatever you prefer!
There was a problem hiding this comment.
I'm fine either way
PR Checklist
status: accepting prsOverview
Initially intended primarily for parking, I also added sections for sponsoring, feedback, and code of conduct.