update sound plugin and captions toggle

.nvmrc

@@ -1 +1 @@
-v16.19.1
+v18.15.0

CHANGELOG.md

@@ -5,6 +5,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.5.0] - unreleased
+
+### Changed
+
+- Prevent SoundPlugin from sending mute state before Application is loaded. 
+- Prevent CaptionsTogglePlugin from sending mute state before Application is loaded. 
+- updated .nvmrc to 18
+
 ## [2.4.6] - 2023-10-16
 
 ### Fixed

README.md

@@ -678,6 +678,6 @@ There is no configuration required for the UserDataPlugin as it just handles req
 
 ## License
 
-Copyright (c) 2022 [SpringRoll](http://github.com/SpringRoll)
+Copyright (c) 2024 [SpringRoll](http://github.com/SpringRoll)
 
 Released under the MIT License.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "springroll-container",
-  "version": "2.4.6",
+  "version": "2.5.0",
   "description": "The iframe controller for interacting with SpringRoll applications",
   "main": "./dist/index.js",
   "license": "MIT",

src/plugins/CaptionsTogglePlugin.js

@@ -65,7 +65,9 @@ export class CaptionsTogglePlugin extends ButtonPlugin {
           return;
         }
 
-        this.captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
+        const captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
+
+        this.setMuteProp('captionsMuted', captionsMuted, this._captionsButtons, true);
 
       }.bind(this)
     );
@@ -74,8 +76,9 @@ export class CaptionsTogglePlugin extends ButtonPlugin {
   * @memberof CaptionsTogglePlugin
   */
   start() {
-    this.captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
-
+    for (let i = 0; i < this.captionsButtonsLength; i++) {
+      this.captionsButtons[i].enableButton();
+    }
     this.client.on('loaded', this.sendAllProperties);
     this.client.on('loadDone', this.sendAllProperties);
   }

src/plugins/SoundPlugin.js

@@ -444,6 +444,19 @@ export class SoundPlugin extends ButtonPlugin {
         for (let i = 0; i < this.voSlidersLength; i++) {
           this.voSliders[i].displaySlider(features.data);
         }
+
+
+        const soundMuted = !!SavedData.read(SoundPlugin.soundMutedKey);
+        const musicMuted = !!SavedData.read(SoundPlugin.musicMutedKey);
+        const sfxMuted = !!SavedData.read(SoundPlugin.sfxMutedKey);
+        const voMuted = !!SavedData.read(SoundPlugin.voMutedKey);
+
+        // set the property in case buttons exist but disable the send here
+        // properties will be sent in sendAllProperties
+        this.setMuteProp('soundMuted', soundMuted, this.soundButtons, true);
+        this.setMuteProp('musicMuted', musicMuted, this.musicButtons, true);
+        this.setMuteProp('sfxMuted', sfxMuted, this.sfxButtons, true);
+        this.setMuteProp('voMuted', voMuted, this.voButtons, true);
       }.bind(this)
     );
   }
@@ -452,7 +465,6 @@ export class SoundPlugin extends ButtonPlugin {
    * @memberof SoundPlugin
    */
   start() {
-
     for (let i = 0; i < this.soundButtonsLength; i++) {
       this.soundButtons[i].enableButton();
     }
@@ -466,11 +478,6 @@ export class SoundPlugin extends ButtonPlugin {
       this.voButtons[i].enableButton();
     }
 
-    this.soundMuted = !!SavedData.read(SoundPlugin.soundMutedKey);
-    this.musicMuted = !!SavedData.read(SoundPlugin.musicMutedKey);
-    this.sfxMuted = !!SavedData.read(SoundPlugin.sfxMutedKey);
-    this.voMuted = !!SavedData.read(SoundPlugin.voMutedKey);
-
     this.client.on('loaded', this.sendAllProperties);
     this.client.on('loadDone', this.sendAllProperties);
   }