Optimize transmute #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use boxes: Not only this avoids allocation but also makes no_std implementation possible. I didn't bother to rewrite the comment (it's not like I entirely understand how it works anyway). but there are 2 main issues to consider: 1) Alignment: union Blank has both the max size and max alignment of its arguments 2) Niches: for some implementation-defined reason this combination of Options and Result works. We likely use the fact that union have no niches. Together with removing black_box and inline(never) this achieves performance identical with std on my ARMv8.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use boxes: Not only this avoids allocation but also makes no_std implementation possible.
I didn't bother to rewrite the comment (it's not like I entirely understand how it works anyway). but there are 2 main issues to consider:
Together with removing black_box and inline(never) this achieves performance identical with std on my ARMv8.