Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Number obfuscation #45

Merged
merged 19 commits into from
Mar 25, 2025
Merged

Improve Number obfuscation #45

merged 19 commits into from
Mar 25, 2025

Conversation

jonesdevelopment
Copy link
Collaborator

@jonesdevelopment jonesdevelopment commented Mar 8, 2025

  • Treat all numbers as longs in encryption
  • Improve number encryption method
  • Scramble all numbers when encrypting
  • Add interface support to arrayed number encryption

Waiting for this to be tested on more samples before merging.

@jonesdevelopment jonesdevelopment self-assigned this Mar 8, 2025
@jonesdevelopment jonesdevelopment changed the title Treat all obfuscated values as longs Improve Number obfuscation Mar 8, 2025
@jonesdevelopment jonesdevelopment marked this pull request as draft March 8, 2025 20:35
@jonesdevelopment jonesdevelopment marked this pull request as ready for review March 9, 2025 15:38
@jonesdevelopment
Copy link
Collaborator Author

I've been using this for my Minecraft plugin for the last few days and it's working without problems.

@SpartanB312 Please test this on some more samples. I'd like to merge this, so it can be released in the next update.

@SpartanB312 SpartanB312 requested a review from xiguajerry March 24, 2025 08:54
Copy link
Collaborator

@xiguajerry xiguajerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code style is mostly fine.

Copy link
Collaborator

@xiguajerry xiguajerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@xiguajerry xiguajerry merged commit da7f3e4 into main Mar 25, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants