Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: spotDL/spotify-downloader
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SongGen-AI/spotify-downloader
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 3 commits
  • 2 files changed
  • 1 contributor

Commits on Mar 18, 2024

  1. fix: disable proxy format check

    @kcoder666
    kcoder666 authored Mar 18, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f9320e0 View commit details

Commits on Apr 18, 2024

  1. Merge branch 'spotDL:master' into master

    @kcoder666
    kcoder666 authored Apr 18, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    fa02351 View commit details

  2. Fix passing array for --proxy param

    @kcoder666
    kcoder666 authored Apr 18, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    GPG key ID: B5690EEEBB952194
    Verified
    Learn about vigilant mode
    Copy the full SHA
    2f64000 View commit details
Showing with 3 additions and 3 deletions.
  1. +2 −2 spotdl/download/downloader.py
  2. +1 −1 spotdl/utils/formatter.py
4 changes: 2 additions & 2 deletions spotdl/download/downloader.py
View file
Original file line number Diff line number Diff line change
@@ -216,8 +216,8 @@ def __init__(
proxy = self.settings["proxy"]
proxies = None
if proxy:
if not re.match(pattern=r"(http|https)://\d{1,5}", string=proxy):
raise DownloaderError(f"Invalid proxy server: {proxy}")
#if not re.match(pattern=r"(http|https)://\d{1,5}", string=proxy):
# raise DownloaderError(f"Invalid proxy server: {proxy}")
proxies = {"http": proxy, "https": proxy}
logger.info("Setting proxy server: %s", proxy)

2 changes: 1 addition & 1 deletion spotdl/utils/formatter.py
View file
Original file line number Diff line number Diff line change
@@ -639,6 +639,6 @@ def args_to_ytdlp_options(argument_list: List[str]) -> Dict[str, Any]:
values.append(argument_list[val_index + 1])
val_index += 1

options_dict[option.dest] = values
options_dict[option.dest] = values if len(values) > 1 else values[0]

return options_dict