-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLCORE-1142 Improve Git blaming for the analysis #1247
Merged
kirill-knize-sonarsource
merged 4 commits into
master
from
feature/kk/git-blame-time-window
Feb 24, 2025
Merged
SLCORE-1142 Improve Git blaming for the analysis #1247
kirill-knize-sonarsource
merged 4 commits into
master
from
feature/kk/git-blame-time-window
Feb 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bd862b3
to
c0d21fe
Compare
94fe8c7
to
9ea9367
Compare
9ea9367
to
625d54b
Compare
1b25257
to
5c8cf22
Compare
5c8cf22
to
f97e0ce
Compare
damien-urruty-sonarsource
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, overall LGTM.
Maybe it would deserve some medium tests to make sure everything is plugged together
backend/commons/src/main/java/org/sonarsource/sonarlint/core/commons/NewCodeDefinition.java
Outdated
Show resolved
Hide resolved
backend/commons/src/main/java/org/sonarsource/sonarlint/core/commons/NewCodeDefinition.java
Outdated
Show resolved
Hide resolved
backend/commons/src/main/java/org/sonarsource/sonarlint/core/commons/util/git/GitUtils.java
Outdated
Show resolved
Hide resolved
5e16a1a
to
f947597
Compare
f947597
to
4487f86
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1142