SLCORE-1141: Don't log an error when closed projects removed #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when users close projects in the Eclipse IDE or when projects are removed on disk but the workspace reference is still in the workspace and the user then deletes this very project from the workspace, an error is logged. As this is a valid situation in Eclipse, rather log a debug message and not an error as nothing is actually failing.
|
nquinquenel
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1141
Currently, when users close projects in the Eclipse IDE or when projects are removed on disk but the workspace reference is still in the workspace and the user then deletes this very project from the workspace, an error is logged.
As this is a valid situation in Eclipse, rather log a debug message and not an error as nothing is actually failing.