SLCORE-716: Mend / Promote task to use Java 17 #1216
Merged
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien-urruty-sonarsource
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
LGTM. Was it needed to bump the version for the promote task too? Anyway, it doesn't hurt.
As discussed yesterday, if ou didn't notice the Mend task was failing, I would never have. After thinking a bit more about it, I think the promotion should fail if Mend fails, WDYT? We could remove line 166
Because the Docker image was setting the Java version conditionally on Cirrus CI.
thahnen
force-pushed
the
fix/tha/SLCORE-716_Mend
branch
from
4e1cb0c to
1afa937
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-716
Because the Docker image was setting the Java version conditionally on Cirrus CI.