Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-1086 Investigate git blame slowness #1192

Closed
wants to merge 1 commit into from
Closed

SLCORE-1086 Investigate git blame slowness #1192

wants to merge 1 commit into from

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Dec 17, 2024 •
edited by jira bot
Loading

thahnen
thahnen reviewed Dec 17, 2024
View reviewed changes
backend/commons/src/main/java/org/sonarsource/sonarlint/core/commons/util/git/GitUtils.java
return new SonarLintBlameResult(blameResult, gitRepoRelativeProjectBaseDir);
} catch (GitAPIException e) {
throw new IllegalStateException("Failed to blame repository files", e);
}
}

private static boolean isGitAvailable() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only run this once and cache this information (e.g. with a static class attribute). Running this is also costly for every Git command 😄

thahnen added a commit that referenced this pull request Jan 27, 2025
@thahnen @nquinquenel
SLCORE-1133: Rely on native Git if possible
537fc0c 
Cherry-picked from #1192

Co-authored-by: Nicolas Quinquenel <nicolas.quinquenel@sonarsource.com>
Reviewed-by: Tobias Hahnen <tobias.hahnen@sonarsource.com>
@thahnen thahnen mentioned this pull request Jan 27, 2025
Merged
@thahnen thahnen closed this Jan 27, 2025
@thahnen thahnen deleted the task/nq/SLCORE-1086-blame-investigation branch January 27, 2025 14:07
kirill-knize-sonarsource pushed a commit that referenced this pull request Feb 9, 2025
@thahnen @nquinquenel @kirill-knize-sonarsource
SLCORE-1133: Rely on native Git if possible
f2dc665 
Cherry-picked from #1192

Co-authored-by: Nicolas Quinquenel <nicolas.quinquenel@sonarsource.com>
Reviewed-by: Tobias Hahnen <tobias.hahnen@sonarsource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thahnen thahnen thahnen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @thahnen