Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-1079 Fix SSF-694 #1186

Merged
merged 2 commits into from
Dec 12, 2024
Merged

SLCORE-1079 Fix SSF-694 #1186

merged 2 commits into from
Dec 12, 2024

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Dec 6, 2024 •
edited by jira bot
Loading

@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1079-ssf-694 branch 2 times, most recently from daa151e to 5c0766a Compare December 10, 2024 12:25
@nquinquenel nquinquenel force-pushed the feature/nq/SLCORE-1079-ssf-694 branch from 5c0766a to f4a31d3 Compare December 10, 2024 12:26
@nquinquenel nquinquenel marked this pull request as ready for review December 10, 2024 12:39
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Dec 10, 2024 •
edited
Loading

Quality Gate passed Quality Gate passed

Issues
0 New issues
21 Fixed issues
3 Accepted issues

Measures
0 Security Hotspots
89.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

kirill-knize-sonarsource
kirill-knize-sonarsource approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server-side logging explicitly checks for the value of the header and doesn't log if it's 'Bearer: ...'
That's why it solves the token logging problem.

@nquinquenel nquinquenel merged commit 71b5f80 into master Dec 12, 2024
13 checks passed
@nquinquenel nquinquenel deleted the feature/nq/SLCORE-1079-ssf-694 branch December 12, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirill-knize-sonarsource kirill-knize-sonarsource kirill-knize-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquinquenel @kirill-knize-sonarsource