SLCORE-1064 Fix the loading of sonar-text analyzer in Connected Mode #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nquinquenel
force-pushed
the
bug/nq/SLCORE-1064-fix-loading-sonar-text
branch
from
38375f9 to
8164c37
Compare
|
sophio-japharidze-sonarsource
approved these changes
Dec 4, 2024
| @@ -179,7 +179,7 @@ public boolean supportsCustomSecrets(String connectionId) { | |||
| return false; | |||
| } | |||
| // when storage is not present, assume that secrets are not supported by server | |||
| return connection.getKind() != ConnectionKind.SONARCLOUD && storageService.connection(connectionId).serverInfo().read() | |||
| return connection.getKind() == ConnectionKind.SONARCLOUD || storageService.connection(connectionId).serverInfo().read() | |||
There was a problem hiding this comment.
It doesn't have to be done for the release but I think a test would help. It was already missing because we did not discover the bug in the first place, now that we are fixing it, I think we should add one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SLCORE-1064