Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLCORE-800 Clean up deprecated classes and methods #1108

Merged
merged 1 commit into from
Jan 21, 2025
Merged

SLCORE-800 Clean up deprecated classes and methods #1108

merged 1 commit into from
Jan 21, 2025

Conversation

kirill-knize-sonarsource
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource commented Sep 25, 2024 •
edited by jira bot
Loading

@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 2 times, most recently from 784675e to 7782a48 Compare October 1, 2024 06:59
@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 2 times, most recently from b8ad028 to 88623f4 Compare October 7, 2024 13:40
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Oct 7, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
330 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 3 times, most recently from 6916138 to a0ea7b7 Compare October 28, 2024 09:40
@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch from a0ea7b7 to 3128538 Compare October 28, 2024 15:19
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
139 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 2 times, most recently from 20a13b2 to 2b37ab0 Compare November 11, 2024 08:56
@sonarqube-next SonarQube-Next
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
13 New issues

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 4 times, most recently from 6d32585 to 4422da8 Compare January 10, 2025 15:50
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
121 Fixed issues
13 Accepted issues

Measures
0 Security Hotspots
94.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 2 times, most recently from f9033cd to 40150d0 Compare January 13, 2025 09:14
@damien-urruty-sonarsource damien-urruty-sonarsource changed the title SLCORE-800 Clean up deprecated classes related to analysis SLCORE-800 Clean up deprecated classes and methods Jan 13, 2025
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch 6 times, most recently from bf5f63f to fde924e Compare January 21, 2025 07:52
@damien-urruty-sonarsource damien-urruty-sonarsource marked this pull request as ready for review January 21, 2025 08:22
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch from fde924e to 48aea00 Compare January 21, 2025 11:13
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch from 48aea00 to 0403ff8 Compare January 21, 2025 11:22
kirill-knize-sonarsource
kirill-knize-sonarsource commented Jan 21, 2025
View reviewed changes
Copy link
Contributor Author

@kirill-knize-sonarsource kirill-knize-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor comments

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch from 0403ff8 to 5b5ee45 Compare January 21, 2025 13:59
@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
210 Fixed issues
2 Accepted issues

Measures
0 Security Hotspots
88.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@damien-urruty-sonarsource damien-urruty-sonarsource merged commit 48c8438 into master Jan 21, 2025
14 checks passed
@damien-urruty-sonarsource damien-urruty-sonarsource deleted the task/kk/SLCORE-800-Clean-up-deprecated-classes-related-to-analysis branch January 21, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damien-urruty-sonarsource damien-urruty-sonarsource damien-urruty-sonarsource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirill-knize-sonarsource @damien-urruty-sonarsource