Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S7142: Supabase API keys should not be disclosed (APPSEC-2231) #4474

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 5, 2024

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource changed the title Create rule S7142 Create rule S7142: Supabase API keys should not be disclosed Nov 6, 2024
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource marked this pull request as ready for review November 7, 2024 12:24
@pierre-loup-tristant-sonarsource pierre-loup-tristant-sonarsource changed the title Create rule S7142: Supabase API keys should not be disclosed Create rule S7142: Supabase API keys should not be disclosed (APPSEC-2231) Nov 7, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor suggestion regarding variable names in the code examples.

rules/S7142/secrets/rule.adoc Outdated Show resolved Hide resolved
Co-authored-by: Pierre-Loup <49131563+pierre-loup-tristant-sonarsource@users.noreply.github.com>
Copy link

sonarqube-next bot commented Nov 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Nov 7, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource merged commit ed65d9d into master Nov 7, 2024
8 of 10 checks passed
@hendrik-buchwald-sonarsource hendrik-buchwald-sonarsource deleted the rule/add-RSPEC-S7142 branch November 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants