Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'INFO' and 'BLOCKER' for rule quality severity #4462

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

erwan-serandour
Copy link
Contributor

With the introduction of the Multi-Quality Rule mode, there are now five different rule quality severities : ["INFO," "LOW," "MEDIUM," "HIGH," "BLOCKER"]. Allow INFO and BLOCKER for rule quality severity.

@erwan-serandour erwan-serandour requested a review from a team October 31, 2024 15:33
@erwan-serandour erwan-serandour added the rspec system Related to handling of rspecs (scripts, doc...) label Oct 31, 2024
@erwan-serandour erwan-serandour requested review from a team and removed request for a team October 31, 2024 15:35
@frederic-tingaud-sonarsource
Copy link
Contributor

Hi Erwan, Thanks for the PR. At the same time as we introduce the 5 levels MQR, I would like to run a script that migrates all existing rules to these new levels. If we don't do both at the same time, it will be complex to know which rule is using the 5-levels scale and which one is using the 3-levels scale.
I'll try to do this early next week.

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource force-pushed the erwan/metadataAcceptBlocker branch 2 times, most recently from ade3a98 to 5cc71a1 Compare November 4, 2024 13:53
@andrei-epure-sonarsource
Copy link
Contributor

are the "func": "Constant\/Issue", changes safe? they seem unrelated.

@andrei-epure-sonarsource
Copy link
Contributor

out of curiosity - I skimmed through the changes and most seem HIGH->BLOCKER changes.

Were there any changes related to the new INFO level?

@frederic-tingaud-sonarsource
Copy link
Contributor

frederic-tingaud-sonarsource commented Nov 4, 2024

are the "func": "Constant\/Issue", changes safe? they seem unrelated.

They are safe. We have an unnecessary escape here and when loading in memory, then dumping the JSON file, these get lost.

Were there any changes related to the new INFO level?

Yes, but a lot less: https://github.com/SonarSource/rspec/pull/4462/files#diff-e4615faea28f2d40898bfdc97c8e08bc43ef2ba73c84d6d09397a0a450707ba4R6
In retrospect, I'd say that it's not surprising, because we try to favor rules that show real problems.

@marco-antognini-sonarsource
Copy link
Contributor

marco-antognini-sonarsource commented Nov 4, 2024

are the "func": "Constant\/Issue", changes safe? they seem unrelated.

They are safe. We have an unnecessary escape here and when loading in memory, then dumping the JSON file, these get lost.

I vaguely remember a similar discussion... because what you say is the theory. 😅

We have this specific code. Why we have it is a mystery to me. Therefore, maybe there is a reason and we should keep the \/. Might be worth checking this does not break anything silently...

@balazs-benics-sonarsource
Copy link
Contributor

are the "func": "Constant\/Issue", changes safe? they seem unrelated.

I'd propose splitting the PR, 1 adding the new categories, and 1 for changing the Constant\/Issue thingy. WDYT?
This is a huge PR, which deserves really narrow motivation.

…agreement

Not migrated because of multiple qualities:
{'common': ['S1523', 'S2077', 'S6821', 'S6967'], 'xml': ['S3281', 'S3355'], 'cfamily': ['S5782', 'S6991', 'S7012', 'S7038', 'S7042'], 'python': ['S6709', 'S6714', 'S6727', 'S6729', 'S6734', 'S6740', 'S6741', 'S6882', 'S6883', 'S6887', 'S6890', 'S6894', 'S6900', 'S6903', 'S6919', 'S6925', 'S6928', 'S6929', 'S6971', 'S6973', 'S6974', 'S6982'], 'javascript': ['S6746', 'S6747', 'S6748', 'S6750', 'S6756', 'S6757', 'S6761', 'S6763', 'S6766', 'S6772', 'S6774', 'S6788', 'S6789', 'S6790', 'S6791', 'S6859', 'S6861', 'S7059', 'S7060'], 'java': ['S6804', 'S6806', 'S6813', 'S6818', 'S6829', 'S6831'], 'kubernetes': ['S6865', 'S6869', 'S6870', 'S6873', 'S6892', 'S6897', 'S6907'], 'csharp': ['S6932'], 'docker': ['S7018', 'S7019', 'S7023', 'S7029', 'S7030']}

Not migrated because of a contradiction between quality and severity, please migrate manually:
{'javascript': ['S1441', 'S2310', 'S3523', 'S5254', 'S6661', 'S6666', 'S6671', 'S6676', 'S6679', 'S6749', 'S6754', 'S6759', 'S6767', 'S6770', 'S6775', 'S6836', 'S6849'], 'common': ['S3723', 'S6620', 'S6667', 'S6668', 'S6669', 'S6670', 'S6672', 'S6674', 'S6675', 'S6776', 'S6930', 'S6931', 'S6934', 'S6960', 'S6964'], 'java': ['S6485', 'S6809', 'S6814', 'S6816', 'S6817', 'S6830', 'S6837', 'S6857', 'S6863', 'S6876', 'S6877', 'S6878', 'S6881', 'S6889', 'S6891', 'S6898', 'S6904', 'S6905', 'S6909', 'S6912', 'S6914', 'S6923', 'S6926', 'S7027'], 'kotlin': ['S6524', 'S6527', 'S6528'], 'python': ['S6660'], 'csharp': ['S6798', 'S6800', 'S6968'], 'cfamily': ['S6936', 'S6996', 'S7032', 'S7040'], 'docker': ['S7020', 'S7021', 'S7026', 'S7031']}

Migrated:
{'cfamily': ['S1032', 'S1036', 'S1232', 'S1760', 'S1912', 'S1914', 'S2806', 'S3491', 'S3519', 'S3520', 'S3529', 'S3584', 'S3588', 'S3590', 'S3654', 'S3657', 'S3692', 'S3729', 'S3936', 'S4997', 'S4999', 'S5000', 'S5018', 'S5020', 'S5184', 'S5267', 'S5302', 'S5404', 'S5417', 'S5486', 'S5487', 'S5489', 'S5502', 'S5553', 'S5639', 'S5798', 'S5912', 'S5999', 'S6025', 'S6223', 'S6427', 'S6493', 'S6655', 'S797', 'S798', 'S912', 'S916', 'S946', 'S961', 'S963', 'S969', 'S978', 'S998'], 'csharp': ['S1048', 'S2306', 'S3237', 'S6422', 'S6424'], 'vbnet': ['S1048'], 'plsql': ['S1058', 'S1074', 'S4577'], 'common': ['S1069', 'S1139', 'S1147', 'S1219', 'S128', 'S1309', 'S1314', 'S1451', 'S1493', 'S1527', 'S1590', 'S1614', 'S1669', 'S1845', 'S1909', 'S2007', 'S2068', 'S2095', 'S2096', 'S2178', 'S2187', 'S2189', 'S2190', 'S2275', 'S2368', 'S2387', 'S2437', 'S2689', 'S2695', 'S2699', 'S2857', 'S2930', 'S2931', 'S2953', 'S2970', 'S3046', 'S3060', 'S3360', 'S3427', 'S3433', 'S3443', 'S3464', 'S3516', 'S3618', 'S3827', 'S3862', 'S3869', 'S3875', 'S3877', 'S3884', 'S3889', 'S3931', 'S4159', 'S4462', 'S5496', 'S5632', 'S5708', 'S6265', 'S6270', 'S6302', 'S6304', 'S6329', 'S6333', 'S6373', 'S6418', 'S6472', 'S6781', 'S6839', 'S999'], 'java': ['S1190', 'S2168', 'S2188', 'S2229', 'S2236', 'S2276', 'S2693', 'S2975', 'S3014', 'S3546', 'S3753', 'S4602', 'S5786', 'S5793', 'S5979', 'S6208', 'S6212', 'S6539', 'S6541', 'S6548', 'S923'], 'pli': ['S131'], 'flex': ['S1446', 'S1466', 'S1468', 'S1469'], 'abap': ['S1496', 'S1508', 'S5117'], 'javascript': ['S1526', 'S2703', 'S2817', 'S3796', 'S6268', 'S6299'], 'php': ['S1599', 'S1799', 'S2014', 'S3333', 'S3334', 'S3336', 'S3337', 'S5335', 'S5911'], 'vb6': ['S1657'], 'cobol': ['S1967', 'S1969', 'S3481', 'S3938'], 'python': ['S2316', 'S2317', 'S2711', 'S2712', 'S2823', 'S2876', 'S3403', 'S5549', 'S5607', 'S5633', 'S5642', 'S5644', 'S5714', 'S5719', 'S5722', 'S5724', 'S5756', 'S5807', 'S5828', 'S5905', 'S5953', 'S6725', 'S6779', 'S930'], 'xml': ['S3282', 'S3374'], 'css': ['S4650', 'S4653', 'S4654', 'S4668'], 'apex': ['S5376', 'S5377', 'S5379', 'S5382', 'S5389'], 'secrets': ['S6292', 'S6334', 'S6335', 'S6336', 'S6337', 'S6338', 'S6652', 'S6684', 'S6686', 'S6687', 'S6688', 'S6689', 'S6690', 'S6691', 'S6692', 'S6693', 'S6694', 'S6695', 'S6696', 'S6697', 'S6698', 'S6699', 'S6700', 'S6701', 'S6702', 'S6703', 'S6704', 'S6705', 'S6706', 'S6708', 'S6710', 'S6713', 'S6717', 'S6718', 'S6719', 'S6720', 'S6721', 'S6722', 'S6723', 'S6731', 'S6732', 'S6733', 'S6736', 'S6739', 'S6751', 'S6752', 'S6753', 'S6755', 'S6758', 'S6760', 'S6762', 'S6764', 'S6765', 'S6768', 'S6769', 'S6771', 'S6773', 'S6777', 'S6782', 'S6783', 'S6910', 'S6987', 'S6988', 'S6989', 'S6990', 'S6992', 'S6993', 'S6995', 'S6997', 'S6998', 'S6999', 'S7000', 'S7001', 'S7002', 'S7003', 'S7004', 'S7006', 'S7007', 'S7008', 'S7009', 'S7010', 'S7011', 'S7013', 'S7014', 'S7015', 'S7016', 'S7017', 'S7022', 'S7024', 'S7025']}

Already good:
{'cfamily': ['S1000', 'S1001', 'S1002', 'S1003', 'S1006', 'S1011', 'S1013', 'S1016', 'S1017', 'S1035', 'S1039', 'S1042', 'S1044', 'S1046', 'S1051', 'S1052', 'S1055', 'S1079', 'S1081', 'S1198', 'S1231', 'S1235', 'S1236', 'S1242', 'S1259', 'S1265', 'S1271', 'S1705', 'S1706', 'S1708', 'S1709', 'S1712', 'S1749', 'S1750', 'S1761', 'S1762', 'S1767', 'S1768', 'S1771', 'S1773', 'S1831', 'S1836', 'S1878', 'S1911', 'S1913', 'S1915', 'S1916', 'S1917', 'S1986', 'S2107', 'S2216', 'S2303', 'S2305', 'S2323', 'S2324', 'S2393', 'S2665', 'S2668', 'S2753', 'S2754', 'S2807', 'S2808', 'S2813', 'S2815', 'S3135', 'S3229', 'S3230', 'S3231', 'S3432', 'S3468', 'S3469', 'S3470', 'S3471', 'S3485', 'S3486', 'S3490', 'S3522', 'S3539', 'S3540', 'S3541', 'S3542', 'S3548', 'S3549', 'S3574', 'S3576', 'S3608', 'S3609', 'S3624', 'S3628', 'S3636', 'S3642', 'S3646', 'S3656', 'S3659', 'S3685', 'S3687', 'S3691', 'S3698', 'S3708', 'S3715', 'S3719', 'S3726', 'S3728', 'S3730', 'S3731', 'S3732', 'S3743', 'S3744', 'S3805', 'S3806', 'S3807', 'S3935', 'S4263', 'S4334', 'S4962', 'S4963', 'S4998', 'S5008', 'S5019', 'S5025', 'S5028', 'S5180', 'S5205', 'S5213', 'S5259', 'S5262', 'S5263', 'S5265', 'S5266', 'S5269', 'S5270', 'S5271', 'S5272', 'S5273', 'S5274', 'S5275', 'S5276', 'S5277', 'S5278', 'S5279', 'S5280', 'S5281', 'S5283', 'S5293', 'S5297', 'S5298', 'S5303', 'S5305', 'S5306', 'S5307', 'S5308', 'S5309', 'S5311', 'S5312', 'S5313', 'S5314', 'S5316', 'S5318', 'S5319', 'S5350', 'S5356', 'S5357', 'S5358', 'S5381', 'S5408', 'S5409', 'S5414', 'S5415', 'S5419', 'S5421', 'S5422', 'S5425', 'S5485', 'S5488', 'S5491', 'S5494', 'S5495', 'S5500', 'S5501', 'S5506', 'S5507', 'S5523', 'S5524', 'S5536', 'S5566', 'S5570', 'S5658', 'S5801', 'S5812', 'S5813', 'S5814', 'S5815', 'S5816', 'S5817', 'S5820', 'S5824', 'S5825', 'S5827', 'S5832', 'S5945', 'S5946', 'S5950', 'S5951', 'S5952', 'S5954', 'S5955', 'S5962', 'S5964', 'S5965', 'S5966', 'S5972', 'S5978', 'S5981', 'S5982', 'S5995', 'S5997', 'S6000', 'S6003', 'S6004', 'S6005', 'S6006', 'S6007', 'S6008', 'S6009', 'S6010', 'S6011', 'S6012', 'S6013', 'S6015', 'S6016', 'S6017', 'S6018', 'S6020', 'S6021', 'S6022', 'S6023', 'S6024', 'S6026', 'S6029', 'S6030', 'S6031', 'S6032', 'S6033', 'S6045', 'S6069', 'S6147', 'S6164', 'S6165', 'S6166', 'S6168', 'S6169', 'S6171', 'S6172', 'S6177', 'S6178', 'S6179', 'S6180', 'S6181', 'S6183', 'S6184', 'S6185', 'S6186', 'S6187', 'S6188', 'S6189', 'S6190', 'S6191', 'S6192', 'S6193', 'S6195', 'S6197', 'S6200', 'S6214', 'S6221', 'S6222', 'S6225', 'S6226', 'S6228', 'S6229', 'S6230', 'S6231', 'S6232', 'S6234', 'S6236', 'S6352', 'S6365', 'S6366', 'S6367', 'S6369', 'S6372', 'S6391', 'S6456', 'S6458', 'S6459', 'S6460', 'S6461', 'S6462', 'S6482', 'S6483', 'S6484', 'S6487', 'S6488', 'S6489', 'S6490', 'S6491', 'S6492', 'S6494', 'S6495', 'S6621', 'S6636', 'S6871', 'S6872', 'S6994', 'S7033', 'S7034', 'S7035', 'S784', 'S793', 'S796', 'S799', 'S810', 'S811', 'S812', 'S813', 'S814', 'S817', 'S819', 'S824', 'S831', 'S833', 'S834', 'S835', 'S841', 'S845', 'S851', 'S853', 'S854', 'S855', 'S856', 'S859', 'S860', 'S868', 'S871', 'S872', 'S873', 'S874', 'S876', 'S877', 'S883', 'S886', 'S890', 'S892', 'S897', 'S919', 'S920', 'S922', 'S924', 'S926', 'S929', 'S936', 'S943', 'S945', 'S950', 'S953', 'S954', 'S955', 'S956', 'S958', 'S959', 'S960', 'S966', 'S967', 'S968', 'S977', 'S982', 'S984', 'S985', 'S986', 'S987', 'S988', 'S989', 'S990', 'S991', 'S994', 'S995'], 'common': ['S1005', 'S1006', 'S103', 'S104', 'S1041', 'S1045', 'S1048', 'S105', 'S1066', 'S1067', 'S1075', 'S1077', 'S108', 'S109', 'S110', 'S1103', 'S1104', 'S1105', 'S1106', 'S1107', 'S1108', 'S1109', 'S1110', 'S1117', 'S1119', 'S112', 'S1120', 'S1121', 'S1124', 'S1125', 'S1126', 'S1131', 'S1138', 'S114', 'S1141', 'S1142', 'S1144', 'S1151', 'S116', 'S1163', 'S1166', 'S1168', 'S117', 'S1170', 'S1176', 'S1181', 'S1188', 'S119', 'S1197', 'S1199', 'S1200', 'S1210', 'S1213', 'S1215', 'S1223', 'S1226', 'S1227', 'S1238', 'S124', 'S1244', 'S125', 'S1258', 'S126', 'S1264', 'S127', 'S1270', 'S1291', 'S1301', 'S131', 'S1312', 'S1313', 'S1321', 'S133', 'S134', 'S135', 'S138', 'S139', 'S140', 'S1438', 'S1439', 'S1440', 'S1444', 'S1448', 'S1449', 'S1450', 'S1472', 'S1479', 'S1488', 'S1492', 'S1498', 'S1499', 'S1515', 'S1516', 'S1536', 'S1537', 'S1542', 'S1543', 'S1545', 'S1546', 'S1548', 'S1573', 'S1583', 'S1601', 'S1607', 'S1615', 'S1619', 'S1631', 'S1639', 'S1642', 'S1643', 'S1645', 'S1654', 'S1656', 'S1659', 'S1694', 'S1695', 'S1696', 'S1698', 'S1699', 'S1700', 'S1707', 'S1735', 'S1737', 'S1738', 'S1739', 'S1741', 'S1742', 'S1745', 'S1751', 'S1763', 'S1764', 'S1772', 'S1774', 'S1784', 'S1788', 'S1820', 'S1821', 'S1848', 'S1858', 'S1862', 'S1872', 'S1899', 'S1905', 'S1939', 'S1940', 'S1941', 'S1944', 'S1952', 'S1990', 'S1994', 'S1996', 'S2004', 'S2005', 'S2011', 'S2024', 'S2039', 'S2042', 'S2047', 'S2092', 'S2094', 'S2097', 'S2108', 'S2114', 'S2122', 'S2123', 'S2139', 'S2145', 'S2147', 'S2148', 'S2151', 'S2156', 'S2164', 'S2166', 'S2177', 'S2183', 'S2184', 'S2193', 'S2197', 'S2198', 'S2201', 'S2208', 'S2209', 'S2219', 'S2221', 'S2222', 'S2223', 'S2225', 'S2228', 'S2234', 'S2245', 'S2250', 'S2251', 'S2252', 'S2253', 'S2257', 'S2259', 'S2301', 'S2302', 'S2304', 'S2309', 'S2321', 'S2325', 'S2326', 'S2327', 'S2333', 'S2335', 'S2339', 'S2340', 'S2342', 'S2343', 'S2344', 'S2345', 'S2346', 'S2357', 'S2360', 'S2365', 'S2372', 'S2373', 'S2376', 'S2384', 'S2386', 'S2429', 'S2436', 'S2440', 'S2445', 'S2479', 'S2490', 'S2523', 'S2527', 'S2551', 'S2583', 'S2589', 'S2629', 'S2637', 'S2638', 'S2639', 'S2658', 'S2674', 'S2688', 'S2692', 'S2701', 'S2738', 'S2760', 'S2814', 'S2830', 'S2925', 'S2951', 'S2955', 'S2959', 'S2966', 'S2997', 'S3010', 'S3011', 'S3038', 'S3047', 'S3052', 'S3059', 'S3063', 'S3065', 'S3087', 'S3215', 'S3218', 'S3222', 'S3235', 'S3236', 'S3241', 'S3242', 'S3244', 'S3249', 'S3252', 'S3254', 'S3261', 'S3263', 'S3317', 'S3330', 'S3346', 'S3353', 'S3363', 'S3366', 'S3376', 'S3397', 'S3398', 'S3400', 'S3403', 'S3414', 'S3415', 'S3416', 'S3431', 'S3440', 'S3449', 'S3453', 'S3457', 'S3458', 'S3466', 'S3518', 'S3543', 'S3577', 'S3598', 'S3603', 'S3604', 'S3626', 'S3630', 'S3633', 'S3641', 'S3643', 'S3650', 'S3651', 'S3655', 'S3696', 'S3699', 'S3717', 'S3752', 'S3801', 'S3830', 'S3871', 'S3872', 'S3874', 'S3878', 'S3887', 'S3890', 'S3898', 'S3900', 'S3902', 'S3903', 'S3904', 'S3906', 'S3908', 'S3921', 'S3925', 'S3926', 'S3927', 'S3937', 'S3958', 'S3966', 'S3972', 'S3973', 'S3981', 'S3984', 'S3985', 'S3990', 'S3992', 'S3993', 'S3994', 'S3995', 'S3996', 'S3997', 'S3998', 'S4004', 'S4005', 'S4015', 'S4018', 'S4022', 'S4023', 'S4025', 'S4026', 'S4030', 'S4036', 'S4040', 'S4054', 'S4060', 'S4109', 'S4136', 'S4143', 'S4144', 'S4158', 'S4165', 'S4188', 'S4196', 'S4200', 'S4201', 'S4210', 'S4220', 'S4225', 'S4260', 'S4274', 'S4275', 'S4277', 'S4413', 'S4428', 'S4456', 'S4457', 'S4487', 'S4502', 'S4507', 'S4508', 'S4524', 'S4545', 'S4581', 'S4583', 'S4586', 'S4635', 'S4639', 'S4721', 'S4738', 'S4787', 'S4790', 'S4792', 'S4797', 'S4801', 'S4828', 'S4970', 'S5034', 'S5042', 'S5122', 'S5141', 'S5148', 'S5245', 'S5247', 'S5256', 'S5257', 'S5260', 'S5261', 'S5264', 'S5320', 'S5322', 'S5324', 'S5359', 'S5361', 'S5443', 'S5603', 'S5604', 'S5679', 'S5689', 'S5691', 'S5693', 'S5713', 'S5725', 'S5728', 'S5730', 'S5732', 'S5734', 'S5736', 'S5739', 'S5742', 'S5743', 'S5753', 'S5757', 'S5759', 'S5766', 'S5770', 'S5779', 'S5780', 'S5781', 'S5783', 'S5785', 'S5797', 'S5802', 'S5804', 'S5842', 'S5843', 'S5845', 'S5846', 'S5850', 'S5852', 'S5855', 'S5857', 'S5860', 'S5863', 'S5867', 'S5868', 'S5869', 'S5915', 'S5939', 'S5958', 'S5994', 'S5996', 'S6001', 'S6002', 'S6019', 'S6035', 'S6112', 'S6145', 'S6146', 'S6194', 'S6202', 'S6203', 'S6218', 'S6245', 'S6249', 'S6252', 'S6258', 'S6273', 'S6275', 'S6281', 'S6288', 'S6291', 'S6293', 'S6300', 'S6303', 'S6308', 'S6319', 'S6323', 'S6326', 'S6327', 'S6328', 'S6330', 'S6331', 'S6332', 'S6350', 'S6353', 'S6354', 'S6359', 'S6362', 'S6363', 'S6364', 'S6374', 'S6375', 'S6376', 'S6378', 'S6379', 'S6380', 'S6381', 'S6383', 'S6387', 'S6388', 'S6395', 'S6396', 'S6397', 'S6401', 'S6402', 'S6403', 'S6405', 'S6407', 'S6412', 'S6413', 'S6414', 'S6417', 'S6444', 'S6463', 'S6469', 'S6470', 'S6471', 'S6474', 'S6500', 'S6502', 'S6504', 'S6506', 'S6507', 'S6513', 'S6561', 'S6562', 'S6563', 'S6566', 'S6575', 'S6580', 'S6585', 'S6588', 'S6602', 'S6603', 'S6605', 'S6607', 'S6608', 'S6609', 'S6610', 'S6612', 'S6613', 'S6617', 'S6618', 'S6656', 'S6664', 'S6673', 'S6677', 'S6678', 'S6958', 'S6966', 'S787', 'S818', 'S820', 'S864', 'S867', 'S878', 'S881', 'S888', 'S899', 'S905', 'S907', 'S909', 'S923', 'S925', 'S930', 'S935', 'S979', 'S997'], 'plsql': ['S1056', 'S1057', 'S1059', 'S1070', 'S1071', 'S141', 'S1478', 'S1703', 'S2221', 'S2491', 'S2492', 'S2517', 'S2519', 'S2520', 'S2538', 'S3874', 'S4062', 'S4081', 'S4421', 'S4575', 'S4576', 'S4584', 'S5047', 'S6467'], 'html': ['S1082', 'S1083', 'S1297', 'S1298', 'S1436', 'S1456', 'S1457', 'S1458', 'S1827', 'S4084', 'S4645', 'S5254', 'S5255', 'S5258'], 'javascript': ['S1082', 'S1090', 'S1528', 'S1529', 'S1530', 'S1533', 'S1534', 'S1535', 'S1539', 'S2137', 'S2138', 'S2392', 'S2424', 'S2427', 'S2428', 'S2430', 'S2685', 'S2692', 'S2713', 'S2870', 'S2871', 'S2990', 'S2999', 'S3001', 'S3003', 'S3402', 'S3498', 'S3499', 'S3500', 'S3504', 'S3513', 'S3514', 'S3524', 'S3525', 'S3531', 'S3533', 'S3579', 'S3616', 'S3686', 'S3735', 'S3757', 'S3758', 'S3760', 'S3782', 'S3785', 'S3786', 'S3798', 'S3799', 'S3800', 'S3812', 'S3834', 'S3854', 'S3863', 'S4043', 'S4084', 'S4124', 'S4125', 'S4137', 'S4138', 'S4139', 'S4140', 'S4156', 'S4157', 'S4204', 'S4322', 'S4323', 'S4324', 'S4325', 'S4326', 'S4327', 'S4328', 'S4335', 'S4619', 'S4621', 'S4622', 'S4623', 'S4624', 'S4634', 'S4782', 'S4798', 'S4822', 'S6079', 'S6080', 'S6092', 'S6324', 'S6325', 'S6351', 'S6426', 'S6435', 'S6438', 'S6439', 'S6440', 'S6441', 'S6442', 'S6443', 'S6477', 'S6478', 'S6479', 'S6480', 'S6481', 'S6486', 'S6509', 'S6522', 'S6523', 'S6534', 'S6544', 'S6550', 'S6551', 'S6557', 'S6564', 'S6565', 'S6568', 'S6569', 'S6571', 'S6572', 'S6578', 'S6583', 'S6590', 'S6594', 'S6598', 'S6635', 'S6637', 'S6638', 'S6643', 'S6644', 'S6645', 'S6647', 'S6650', 'S6653', 'S6654', 'S6657', 'S6660', 'S6854', 'S6855', 'S6957', 'S6959', 'S930'], 'java': ['S1111', 'S1113', 'S1130', 'S1132', 'S1149', 'S1150', 'S1153', 'S1157', 'S1158', 'S1160', 'S1162', 'S1165', 'S1171', 'S1174', 'S1175', 'S118', 'S1182', 'S1191', 'S1193', 'S1194', 'S1195', 'S1201', 'S1214', 'S1217', 'S1220', 'S1221', 'S1228', 'S1310', 'S1315', 'S1317', 'S1319', 'S1452', 'S1596', 'S1598', 'S1602', 'S1604', 'S1610', 'S1611', 'S1612', 'S1640', 'S1641', 'S1710', 'S1711', 'S1844', 'S1849', 'S1860', 'S1942', 'S1943', 'S1948', 'S1989', 'S2039', 'S2055', 'S2057', 'S2059', 'S2060', 'S2061', 'S2062', 'S2063', 'S2065', 'S2066', 'S2093', 'S2109', 'S2110', 'S2111', 'S2112', 'S2116', 'S2118', 'S2119', 'S2121', 'S2127', 'S2129', 'S2130', 'S2133', 'S2134', 'S2140', 'S2141', 'S2142', 'S2143', 'S2153', 'S2154', 'S2157', 'S2160', 'S2162', 'S2167', 'S2176', 'S2185', 'S2186', 'S2196', 'S2200', 'S2203', 'S2204', 'S2211', 'S2226', 'S2230', 'S2232', 'S2235', 'S2254', 'S2272', 'S2273', 'S2274', 'S2293', 'S2308', 'S2388', 'S2390', 'S2438', 'S2441', 'S2442', 'S2444', 'S2446', 'S2447', 'S2629', 'S2675', 'S2676', 'S2677', 'S2694', 'S2698', 'S2701', 'S2718', 'S2786', 'S2789', 'S2864', 'S2885', 'S2886', 'S2924', 'S2972', 'S2973', 'S2974', 'S3008', 'S3012', 'S3020', 'S3030', 'S3032', 'S3034', 'S3039', 'S3042', 'S3064', 'S3066', 'S3067', 'S3077', 'S3078', 'S3305', 'S3306', 'S3436', 'S3437', 'S3551', 'S3553', 'S3578', 'S3599', 'S3631', 'S3658', 'S3725', 'S3740', 'S3749', 'S3750', 'S3751', 'S3824', 'S3864', 'S3959', 'S3986', 'S4011', 'S4032', 'S4034', 'S4042', 'S4065', 'S4087', 'S4174', 'S4248', 'S4266', 'S4276', 'S4288', 'S4348', 'S4349', 'S4351', 'S4424', 'S4425', 'S4434', 'S4435', 'S4449', 'S4454', 'S4488', 'S4512', 'S4517', 'S4544', 'S4551', 'S4601', 'S4605', 'S4682', 'S4684', 'S4719', 'S4838', 'S4925', 'S4926', 'S4929', 'S4968', 'S4973', 'S5128', 'S5164', 'S5194', 'S5301', 'S5329', 'S5411', 'S5413', 'S5612', 'S5663', 'S5664', 'S5665', 'S5669', 'S5738', 'S5776', 'S5777', 'S5778', 'S5790', 'S5803', 'S5810', 'S5826', 'S5831', 'S5833', 'S5838', 'S5840', 'S5841', 'S5853', 'S5854', 'S5866', 'S5917', 'S5960', 'S5961', 'S5967', 'S5969', 'S5970', 'S5976', 'S5977', 'S5993', 'S5998', 'S6068', 'S6070', 'S6073', 'S6103', 'S6104', 'S6126', 'S6201', 'S6204', 'S6205', 'S6206', 'S6209', 'S6211', 'S6213', 'S6216', 'S6217', 'S6219', 'S6241', 'S6242', 'S6243', 'S6244', 'S6246', 'S6262', 'S6263', 'S6320', 'S6322', 'S6355', 'S6411', 'S6416', 'S6466', 'S6646', 'S6649', 'S6651', 'S6707', 'S6780', 'S6810', 'S6832', 'S6833', 'S6838', 'S6856', 'S6862', 'S6880', 'S6885', 'S6901', 'S6906', 'S6913', 'S6915', 'S6916', 'S6976'], 'python': ['S1129', 'S1244', 'S1716', 'S1720', 'S1722', 'S2318', 'S2319', 'S2320', 'S2710', 'S2772', 'S2836', 'S5655', 'S5685', 'S5704', 'S5706', 'S5707', 'S5709', 'S5712', 'S5717', 'S5720', 'S5727', 'S5747', 'S5754', 'S5795', 'S5796', 'S5799', 'S5806', 'S5864', 'S5886', 'S5890', 'S5899', 'S5906', 'S5914', 'S5918', 'S6464', 'S6465', 'S6466', 'S6468', 'S6537', 'S6538', 'S6540', 'S6542', 'S6543', 'S6545', 'S6546', 'S6552', 'S6553', 'S6554', 'S6556', 'S6559', 'S6560', 'S6711', 'S6730', 'S6735', 'S6742', 'S6785', 'S6786', 'S6792', 'S6794', 'S6795', 'S6796', 'S6799', 'S6886', 'S6899', 'S6908', 'S6911', 'S6918', 'S6969', 'S6972', 'S6978', 'S6979', 'S6983', 'S6984', 'S6985'], 'cobol': ['S1137', 'S1184', 'S1274', 'S1275', 'S1276', 'S1277', 'S1278', 'S1279', 'S1280', 'S1281', 'S1282', 'S1283', 'S1284', 'S1285', 'S1287', 'S1288', 'S1289', 'S1290', 'S1292', 'S1293', 'S1299', 'S1300', 'S1302', 'S1303', 'S1305', 'S1306', 'S1307', 'S1308', 'S1316', 'S1437', 'S1461', 'S1471', 'S1473', 'S1474', 'S1475', 'S1476', 'S1550', 'S1579', 'S1580', 'S1582', 'S1587', 'S1589', 'S1682', 'S1683', 'S1685', 'S1686', 'S1691', 'S1692', 'S1693', 'S1713', 'S1723', 'S1725', 'S1726', 'S1728', 'S1729', 'S1731', 'S1732', 'S1740', 'S1747', 'S1755', 'S1966', 'S2269', 'S3004', 'S3394', 'S3482', 'S3483', 'S3515', 'S3573', 'S3580', 'S3581', 'S3582', 'S3592', 'S3595', 'S3606', 'S3613', 'S3614', 'S3620', 'S3621', 'S3625', 'S3632', 'S3671', 'S3767', 'S3891', 'S3892', 'S3939', 'S4727', 'S4882', 'S4883', 'S4884'], 'csharp': ['S1192', 'S1313', 'S1944', 'S2290', 'S2291', 'S2292', 'S2328', 'S2330', 'S2743', 'S2934', 'S2952', 'S2995', 'S2996', 'S3005', 'S3168', 'S3169', 'S3172', 'S3216', 'S3217', 'S3220', 'S3234', 'S3246', 'S3247', 'S3251', 'S3253', 'S3256', 'S3260', 'S3262', 'S3264', 'S3265', 'S3267', 'S3343', 'S3441', 'S3442', 'S3444', 'S3445', 'S3447', 'S3450', 'S3451', 'S3456', 'S3459', 'S3532', 'S3597', 'S3600', 'S3610', 'S3876', 'S3880', 'S3881', 'S3885', 'S3897', 'S3909', 'S3928', 'S3956', 'S3963', 'S3967', 'S3971', 'S4000', 'S4002', 'S4017', 'S4019', 'S4027', 'S4035', 'S4039', 'S4041', 'S4047', 'S4049', 'S4050', 'S4052', 'S4055', 'S4056', 'S4057', 'S4058', 'S4059', 'S4061', 'S4069', 'S4070', 'S4211', 'S4212', 'S4226', 'S4261', 'S6419', 'S6420', 'S6421', 'S6423', 'S6640', 'S6797', 'S6802', 'S6803', 'S6961', 'S6962', 'S6965'], 'flex': ['S1320', 'S1321', 'S1434', 'S1435', 'S1445', 'S1447', 'S1455', 'S1462', 'S1463', 'S1464', 'S1465', 'S1467', 'S1470', 'S1982'], 'abap': ['S1485', 'S1486', 'S1487', 'S1491', 'S1494', 'S1500', 'S1501', 'S1502', 'S1505', 'S1506', 'S1507', 'S1510', 'S1511', 'S1512', 'S1540', 'S1547', 'S1549', 'S1597', 'S1655', 'S1668', 'S1670', 'S1671', 'S1672', 'S1673', 'S1675', 'S1676', 'S1715', 'S2237', 'S2239', 'S2240', 'S2241', 'S2242', 'S2243', 'S2809', 'S5115', 'S5118'], 'php': ['S1600', 'S1603', 'S1605', 'S1757', 'S1765', 'S1766', 'S1779', 'S1780', 'S1781', 'S1793', 'S1808', 'S1997', 'S1998', 'S2000', 'S2001', 'S2002', 'S2003', 'S2010', 'S2036', 'S2037', 'S2038', 'S2043', 'S2044', 'S2046', 'S2050', 'S2918', 'S3335', 'S4824', 'S4833', 'S5328', 'S5899', 'S5935', 'S6339', 'S6341', 'S6343', 'S6344', 'S6345', 'S6346', 'S6347', 'S6348', 'S6349', 'S6393', 'S6600'], 'rpg': ['S1608', 'S1617', 'S1618', 'S1620', 'S1621', 'S1622', 'S1624', 'S1625', 'S1626', 'S1627', 'S1629', 'S1630', 'S1632', 'S1633', 'S1634', 'S1752', 'S1753', 'S1816', 'S1880', 'S1895', 'S1900', 'S1901', 'S1902', 'S2016', 'S2025', 'S2031', 'S2202', 'S2793', 'S2795', 'S2798', 'S2803'], 'vb6': ['S1647', 'S1648', 'S1649', 'S1650', 'S1651', 'S1652', 'S1658', 'S1660', 'S1702'], 'xml': ['S1778', 'S3373', 'S3417', 'S3419', 'S3420', 'S3421', 'S3422', 'S3423', 'S3438', 'S3439', 'S3822', 'S5594', 'S6358', 'S6361'], 'kotlin': ['S2116', 'S5612', 'S6305', 'S6306', 'S6307', 'S6309', 'S6310', 'S6311', 'S6312', 'S6313', 'S6314', 'S6315', 'S6316', 'S6318', 'S6508', 'S6510', 'S6511', 'S6512', 'S6514', 'S6515', 'S6516', 'S6517', 'S6518', 'S6519', 'S6529', 'S6530', 'S6532', 'S6558', 'S6611', 'S6615', 'S6623', 'S6624', 'S6625', 'S6626', 'S6629', 'S6631', 'S6634'], 'vbnet': ['S2347', 'S2348', 'S2349', 'S2352', 'S2354', 'S2355', 'S2359', 'S2362', 'S2363', 'S2364', 'S2366', 'S2367', 'S2369', 'S2370', 'S2374', 'S2375', 'S3385', 'S3860', 'S3866', 'S5944'], 'swift': ['S2635', 'S2950', 'S2957', 'S2958', 'S2960', 'S2961', 'S2962', 'S2967', 'S2968', 'S2969', 'S3083', 'S3086', 'S3110', 'S3111', 'S3661', 'S4173', 'S4184', 'S4186', 'S4233'], 'tsql': ['S3643', 'S4075', 'S4078', 'S4094', 'S4102', 'S4103', 'S4104', 'S4108', 'S4149', 'S4154', 'S4155', 'S4819', 'S4820', 'S6498'], 'pli': ['S3982', 'S4208', 'S4806', 'S5348'], 'css': ['S4648', 'S4649', 'S4651', 'S4652', 'S4655', 'S4656', 'S4657', 'S4658', 'S4659', 'S4660', 'S4661', 'S4662', 'S4664', 'S4666', 'S4667', 'S4670'], 'apex': ['S5378', 'S5384', 'S5386', 'S5387', 'S5390', 'S5394', 'S5395'], 'terraform': ['S6255', 'S6400', 'S6404', 'S6406', 'S6408', 'S6409', 'S6410'], 'cloudformation': ['S6294', 'S6295'], 'text': ['S6389'], 'docker': ['S6476', 'S6497', 'S6505', 'S6570', 'S6573', 'S6574', 'S6579', 'S6581', 'S6584', 'S6586', 'S6587', 'S6589', 'S6595', 'S6597', 'S7028'], 'kubernetes': ['S6893']}
@frederic-tingaud-sonarsource
Copy link
Contributor

I change the PR to put back the \ in "Constant\/Issue".

Copy link

sonarqube-next bot commented Nov 5, 2024

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Nov 5, 2024

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@frederic-tingaud-sonarsource frederic-tingaud-sonarsource merged commit 1b03c3f into master Nov 5, 2024
8 of 9 checks passed
@frederic-tingaud-sonarsource frederic-tingaud-sonarsource deleted the erwan/metadataAcceptBlocker branch November 5, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common rspec system Related to handling of rspecs (scripts, doc...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants