Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect editor style name for Unity 2022.3+ #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shimmermare
Copy link

@Walter-Hulsebos
Copy link

In Unity's own repos they use this, we probably wanna match that

#if UNITY_2023_2_OR_NEWER || UNITY_2021_3_28 || UNITY_2022_3_1

@Shimmermare
Copy link
Author

In Unity's own repos they use this, we probably wanna match that

#if UNITY_2023_2_OR_NEWER || UNITY_2021_3_28 || UNITY_2022_3_1

Good point. Though I don't think there are defines for UNITY_2021_3_28_OR_NEWER and UNITY_2022_3_1_OR_NEWER, so I replaced define checks with simple null check.

@hgrandry
Copy link

hgrandry commented Jun 6, 2024

Hi. Any reason why this has not been merged?

I have created a fork of this repo to do the exact same fix and pull the fix from the package manager. I imagine a lot of people using this package with a somewhat recent version of Unity has the same problem (any version above ~2021.3.14 apparently).

Same for this PR on the UnityDropdown repo: SolidAlloy/UnityDropdown#2

@buzzrick
Copy link

buzzrick commented Jul 4, 2024

+1 for merging this and the UnityDropdown one please. I was also in the process of forking to create the same fix before I realised it was already a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ToolbarSearchCancelButton" fixed in newer version of Unity.
4 participants