Add API versioning and localfile parallel read with grep #526
+748
−331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mwalas
changed the title
…s/sansshell into mwalas-localfile-read-grep
…s/sansshell into mwalas-localfile-read-grep
sfc-gh-mwalas
changed the title
sfc-gh-ikryvanos
requested changes
Feb 10, 2025
sfc-gh-psmolenski
approved these changes
Feb 10, 2025
…s/sansshell into mwalas-localfile-read-grep
sfc-gh-ikryvanos
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to read multiple files at once through a wildcard syntax on a directory (limited only to a single trailing
*for the time being).This change also introduces a simple API versioning. Reason being:
grepetc do not meaningfully extend the application of the method/*syntax allows to skip potential deny rules on reading particular file in subdirectory in rego in a situation where someone allowed reading files in general for a suffix of/tmp/examplebut later added a deny rule for exact path of/tmp/example/secretAPI versioning proposal is covered in
README.md.