Updated dependencies and fix minor issue on browser-sync #29
Conversation
|
ciao @ilterra, |
There was a problem hiding this comment.
Thanks @stefanonava77 ,
I've added my comments on the request.
| */ | ||
| if(isProduction) { |
There was a problem hiding this comment.
Can you double check images are not minified in their original source but only when moved to the build folder?
There was a problem hiding this comment.
Why we can't use the same approach that we use on prod? Do we need images not minified for dev env?
There was a problem hiding this comment.
I remember I had issues with minification. In particular minification was done on images on their location in src (resulting in a git change) instead of first copying them to build and then apply minification.
Can you check the script doesn't minify images in src but only in build?
There was a problem hiding this comment.
Checked by adding a new image: no changes on src folder
No description provided.