-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show refs for repos with tags (or other "unexpected" refs) #222
Comments
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏. |
Not stale, this is important! |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏. |
We've got to fix this. It won't take long and it will exclude lots of user's repos. |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏. |
I've cleaned up this code and it seems to be working now. Closing. |
If the code in
handleGetRefs
throws any kind of error, we just return an emptyRefs()
object.The error swallowing was presumably for dealing with calls to
show-ref
in empty repos, but it's also swallowing errors parsing refs.Need to change this so the try/catch block is only around the call to
show-ref
and not the parsing bit, so that parsing errors are still thrown.The text was updated successfully, but these errors were encountered: