Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addProduct not allowed during addJob #17

Open
Smanmos opened this issue Nov 12, 2021 · 1 comment
Open

addProduct not allowed during addJob #17

Smanmos opened this issue Nov 12, 2021 · 1 comment

Comments

@Smanmos
Copy link
Owner

Smanmos commented Nov 12, 2021

addjob addproduct.png

addProduct is not allowed when performing addJob, contrary to the UG

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 16, 2021

Team's Response

This is incorrect because addProduct can indeed be used after the addJob command is issued without a PRODUCT_INDEX. This is in accordance with the behaviour described in the UG (especially section outlined in red).

Screenshot 2021-11-13 at 8.33.10 PM.png

Here is an example

First if the command addJob d/Change CPU fee/$50 by/13/11/2021 is executed you should see (Note: the expected completion date had to be changed to 13/11/2021 from 10/11/2021 because expected completion date has to be on or after the received date. And if received date (which is an optional parameter in the command) is not provided, by default it is the date the job is being added on (also stated in the UG above). Remember to change the date accordingly based on when you decide to try this command. )

Screenshot 2021-11-13 at 9.23.39 PM.png

Next if you issue the command addContact n/Jack Ryan c/94678954 a/Blk 65 Tampines Ave 1 e/jryan@gmail.com, you should see:

Screenshot 2021-11-13 at 9.23.52 PM.png

Lastly if you issue addProduct n/Asus DUAL-GTX1060-O6G t/GPU m/Asus d/DisplayPort, HDMI, which is what this issue is talking about, you see that it is indeed executed successfully and both the product and the job have been added successfully.

Screenshot 2021-11-13 at 9.24.05 PM.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.Rejected]

  • I disagree

Reason for disagreement: [replace this with your explanation]


❓ Issue severity

Team chose [severity.Low]
Originally [severity.Medium]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants