Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot redirect to project page for the first time #155

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

NarwhalChen
Copy link
Collaborator

@NarwhalChen NarwhalChen commented Mar 5, 2025

Summary by CodeRabbit

  • Refactor
    • Improved chat session navigation for smoother transitions and a more integrated user experience.

Copy link
Contributor

coderabbitai bot commented Mar 5, 2025

Walkthrough

The change updates the navigation mechanism in the sidebar component by replacing the manual history API with Next.js routing. Instead of using window.history.replaceState to update the URL, the component now uses the router.push method from the next/navigation package. This streamlines the navigation to chat sessions by adhering to the Next.js framework conventions.

Changes

Files Change Summary
frontend/src/components/sidebar.tsx Replaced window.history.replaceState with router.push for navigation; added useRouter hook from next/navigation.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant SB as Sidebar Component
    participant R as Next.js Router
    participant CP as Chat Page

    U->>SB: Select chat session
    SB->>R: Call router.push(`/chat?id=${chat.id}`)
    R->>CP: Render chat page with selected chat
Loading

Poem

In the code garden where we play,
I, a hopping rabbit, lead the way.
With a push by router, chat doors swing wide,
New paths in Next.js, a smoother ride.
Hip hop, code pop, let the bugs hide!
🌸🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

frontend/src/components/sidebar.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct.

The config "next/core-web-vitals" was referenced from the config file in "/frontend/.eslintrc.json".

If you still have problems, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
frontend/src/components/sidebar.tsx (1)

55-57: Consider using router.push for consistency in handleNewChat.

While you've correctly updated the chat selection navigation to use Next.js routing, the handleNewChat function still uses the direct history API. For consistency and to prevent similar issues, consider using the router here as well.

const handleNewChat = useCallback(() => {
-  window.history.replaceState({}, '', '/');
+  router.push('/');
  setCurrentChatid('');
  const event = new Event(EventEnum.NEW_CHAT);
  window.dispatchEvent(event);
}, []);

Note: Don't forget to add router to the dependency array of useCallback.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b616285 and 0833d6b.

📒 Files selected for processing (1)
  • frontend/src/components/sidebar.tsx (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Install and Build Frontend
🔇 Additional comments (3)
frontend/src/components/sidebar.tsx (3)

23-23: Good addition of Next.js routing capabilities.

Adding the useRouter import from next/navigation is the correct approach for implementing client-side navigation in Next.js applications.


61-61: Proper initialization of the router hook.

The router is correctly initialized at the component's top level as required for React hooks.


156-156: Improved navigation mechanism fixes the redirect issue.

Replacing the previous window.history.replaceState approach with router.push is the correct solution to fix the redirect issue. This change ensures proper navigation to the project page by triggering a full route change rather than just updating the URL.

@Sma1lboy Sma1lboy self-requested a review March 5, 2025 00:39
@Sma1lboy Sma1lboy merged commit 90ebd1f into main Mar 5, 2025
3 of 4 checks passed
@Sma1lboy Sma1lboy deleted the fix-redirect-bug-in-home-page branch March 5, 2025 00:40
PengyuChen01 pushed a commit that referenced this pull request Mar 5, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Refactor**
- Improved chat session navigation for smoother transitions and a more
integrated user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
PengyuChen01 pushed a commit that referenced this pull request Mar 5, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

- **Refactor**
- Improved chat session navigation for smoother transitions and a more
integrated user experience.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants