-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(frontend): fix some fd UI styling #136
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2ec29de
feat(components): add tab component with transition effects
Sma1lboy 55e9eab
feat(frontend): update color palette and add moving border component
Sma1lboy 99aa232
feat(nav): add floating navbar component with tab transition effects
Sma1lboy f53556b
[autofix.ci] apply automated fixes
autofix-ci[bot] 9bbead5
feat(layout): add About page and integrate NavLayout component
Sma1lboy 3eb24af
Merge branch 'main' into chore-fix-some-fd-ui-styling
Sma1lboy 6fe967d
feat(project): enhance project model with public status, subscription…
Sma1lboy 451e06d
feat(project): add project visibility, forking functionality, and enh…
Sma1lboy bb76c4b
feat(chat): add userId relation for easier access to user ID in chat …
Sma1lboy ab4f8d1
feat(graphql): add userId field to Chat type and implement user proje…
Sma1lboy 2990eb0
feat(chat): integrate ProjectProvider and add project status monitori…
Sma1lboy d787cf4
feat(docker): update Node.js version and improve Dockerfile commands
Sma1lboy bdfb818
feat: implement new authentication flow and improve user session mana…
Sma1lboy 33951c5
feat(frontend): homepage sidebar (#138)
PengyuChen01 cd6029a
[autofix.ci] apply automated fixes
autofix-ci[bot] ce97993
feat(project): add fetchPublicProjects query and input type for proje…
Sma1lboy 7ed0cd7
feat(prompt-form): add input focus tracking and optimize visibility d…
Sma1lboy 6cfd88a
feat: refactor model tag fetching and enhance project name generation…
Sma1lboy 5dab530
feat(backend): adding prompt tools (#141)
Sma1lboy 14a016b
feat: remove unused public projects query and enhance prompt tool des…
Sma1lboy 4c7b804
fix the file name not follow xxx-xxx
0295243
Merge branch 'main' into chore-fix-some-fd-ui-styling
Sma1lboy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Consider standardizing null checking operators
Line 98 uses logical OR (
||
) for fallback while line 94 uses nullish coalescing (??
). This subtle difference could lead to unexpected behavior ifinput.model
is falsy but not null/undefined (like an empty string).🏁 Script executed:
Length of output: 1079
Attention: Standardizing Fallback Operator Usage
It appears that in
backend/src/common/model-provider/openai-model-provider.ts
there is an inconsistent use of fallback operators. At line 94 the code uses nullish coalescing (??
), while at line 98 it falls back using logical OR (||
). This discrepancy can lead to unexpected behavior wheninput.model
is a falsy value (like an empty string) that isn’t null or undefined. Similar patterns using||
are also found inbackend/src/project/project.service.ts
.backend/src/common/model-provider/openai-model-provider.ts
const queue = this.getQueueForModel(input.model ?? this.defaultModel);
model: input.model || this.baseModel,
backend/src/project/project.service.ts
model: input.model || this.model.baseModel,
Recommendation: Please standardize the null checking operator across the codebase. If empty strings or other falsy values should be preserved, consider using
??
consistently for fallback. Otherwise, add inline comments to clarify the rationale behind using different operators if the behavior is intended.