Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ik_two_bone_job tests #87

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix ik_two_bone_job tests #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/ik_two_bone_job.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,8 @@ mod ik_two_bone_tests {
Mat4::from_rotation_translation(Quat::from_axis_angle(Vec3::Z, core::f32::consts::FRAC_PI_2), Vec3::Y);
let base_end = Mat4::from_translation(Vec3::X + Vec3::Y);
let mid_axis = Vec3A::cross(
Vec3A::from(base_start.col(3)) - Vec3A::from(base_mid.col(3)),
Vec3A::from(base_end.col(3)) - Vec3A::from(base_mid.col(3)),
Vec3A::from_vec4(base_start.col(3)) - Vec3A::from_vec4(base_mid.col(3)),
Vec3A::from_vec4(base_end.col(3)) - Vec3A::from_vec4(base_mid.col(3)),
);

let parents = [
Expand Down Expand Up @@ -585,8 +585,8 @@ mod ik_two_bone_tests {
let mid = Mat4::from_rotation_translation(Quat::from_axis_angle(Vec3::Z, consts::FRAC_PI_2), Vec3::Y);
let end = Mat4::from_translation(Vec3::X + Vec3::Y);
let mid_axis = Vec3A::cross(
Vec3A::from(start.col(3)) - Vec3A::from(mid.col(3)),
Vec3A::from(end.col(3)) - Vec3A::from(mid.col(3)),
Vec3A::from_vec4(start.col(3)) - Vec3A::from_vec4(mid.col(3)),
Vec3A::from_vec4(end.col(3)) - Vec3A::from_vec4(mid.col(3)),
);

let mut job = IKTwoBoneJob::default();
Expand Down Expand Up @@ -974,7 +974,7 @@ mod ik_two_bone_tests {
let end = Mat4::from_translation(Vec3::X + Vec3::Y);

let mut job = IKTwoBoneJob::default();
job.set_target(Vec3A::from(start.col(3)));
job.set_target(Vec3A::from_vec4(start.col(3)));
job.set_start_joint(start);
job.set_mid_joint(mid);
job.set_end_joint(end);
Expand Down
Loading