Skip to content

Commit

Permalink
Add Skyline.DataMiner.CICD.Validators.Common.Testing to the Internals…
Browse files Browse the repository at this point in the history
…VisibleTo (#26)

* Small tweak for the validators

* Enable again for DIS (still needed there)

* Removed InternalsVisibleTo for DIS & Validator and removed unnecessary ctor.
  • Loading branch information
MichielOda authored Jan 8, 2024
1 parent ff74ee7 commit 1cae752
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 20 deletions.
10 changes: 2 additions & 8 deletions Protocol/Models/Edit/Protocol/Protocol.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,11 @@ public partial class Protocol
"Name", "Description", "Version","Provider", "Vendor", "VendorOID", "DeviceOID", "ElementType", "Type", "Display", "SNMP",
"DVEs", "ExportRules", "Params", "QActions", "Groups", "Triggers", "Actions", "Timers", "PortSettings"
};

// Used by DIS > SLDisUnitTestsShared > ProtocolTestsHelper.cs

internal Protocol(Read.IProtocol read, EditXml.XmlElement editNode) : base(read, null, editNode)
{
}

// Used by DIS > SLDisUnitTestsShared > ProtocolTestsHelper.cs
internal Protocol(Read.IProtocol read) : base(read, null, CreateEditNode(read))
{
}


public override string[] ElementOrder => elementOrder;

protected override void OnCreated()
Expand Down
11 changes: 2 additions & 9 deletions Protocol/Models/Edit/ProtocolDocumentEdit.cs
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,8 @@ public ProtocolDocumentEdit(IProtocolModel protocolModel, XmlDocument document)

public Protocol Protocol
{
get
{
return protocol;
}

set
{
AssignProtocol(value);
}
get => protocol;
set => AssignProtocol(value);
}

#endregion
Expand Down
3 changes: 0 additions & 3 deletions Protocol/Protocol.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,6 @@

<ItemGroup>
<InternalsVisibleTo Include="$(MSBuildProjectName)Tests" />

<!-- Needed for DIS -->
<InternalsVisibleTo Include="SLDisUnitTestsShared" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 1cae752

Please sign in to comment.