Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new field to transaction messages for passphrase option #1

Open
vidya88 opened this issue Sep 19, 2019 · 0 comments
Open

Add new field to transaction messages for passphrase option #1

vidya88 opened this issue Sep 19, 2019 · 0 comments

Comments

@vidya88
Copy link

vidya88 commented Sep 19, 2019

@stdevAdrianPaez commented 19 days ago

Is your feature request related to a problem? Please describe.
For resolve issue skycoin/hardware-wallet#250 I need modify the transaction messages.

Describe the solution you'd like
Add to transaction messages a new boolean field indicating if passphrase is used to signing transaction or not.

Describe alternatives you've considered
I don't see another solution

Additional context
Need for skycoin/hardware-wallet#250
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[protob] refs #1 - Initialize protob definitions with hardware-wallet…
e3bcce3 
… definitions
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Initial Makefile including following targets:
f1015d7 
- help
- install-deps-{go,js,nanopb} : Install dependencies for language-specific code generation
- build-{go,js,nanopb} : Generate source for a given language
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[js] refs #1 - make targets for generating js classes for protbuf
0ef9956
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] [py] refs #1 - Generate C and Python classes from protobuffer me…
16f98da 
…ssage definitions
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Travis scripts to build on linux and osx
9aebd67
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
refs #1 - Travis lang is python 3.5. Install go with gimme. All binar…
2a0ccb2 
…ies in $HOME/bin
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Activate Python 3.5.0 on Travis osx builds
98713fc
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Travis language=python for linux but genric for osx
49f90af 
... aimed at fixing https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181067097#L51-L55
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Add missing echo command
c3c9496
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Fix conditional block to compute OS_NAME given UNAME_S…
2c4cc04 
…. Move proto defs to proto/messages
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Install protoc only if missing
3824e46
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Deal with existing checkout of protobuf go library
e56e7e2
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] [google] [msg] refs #1 - Add Google descriptor proto file. Use v…
0793a29 
…ars for protobuf in/out folders

... aimed at fixing https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181095515#L560-L578
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Fix syntax error in make install-deps-go
96e6ebc 
... reported in https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181761791#L540-L549
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Check whether a file exists at path of go protobuffer …
d960d02 
…library, no matter the type
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Strip dir path before expaniding PROTOB_MSG_* vars
f38a72d
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - protoc output is lang folder, not file path
c51a44e
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - PROTOB_MSG_GO => PROTOB_GO_DIR when building .pb.go files
3b587ff
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Run make build-* targets in Travis script
a76e07c
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Generate protoc go only on Travis builds
f481988
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
refs #1 - Entry for go lang generation in changelog
c2a6609
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Export GOPATH if not set for Travis build (usually for…
a3c2b66 
… os=osx)
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - @echo => echo in Makefile
0c495fc 
... reported as an issue in https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181820169#L1638-L1649
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Fix typos causing error if github.com/gogo/protobuf fo…
90416cc 
…und in local FS
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - If GOPATH set manually add its bin subfolder to PATH
181f09f
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
Merge pull request #3 from simelo/olemis_t1_protob_init
6dc81e2 
refs #1 - Generate go classes from protobuffer specs
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Correct path to protobuffer messages to build-js
fe4324b
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Correct path to nanopb generator
241852a
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Output folders for py and c directly under root folder…
3ad8b25 
… (instead of nanopb)
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Activate build-py and build-c on Travis builds
08e2089
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - build-nanopb => build-c
2906e8f
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Include Google descriptor.proto to generate c/messages…
63710e9 
…_map.h

... aimed at fixing https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181854195#L568-L575
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - make clean . Test in Travis using git status
f046225
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
refs #1 - C, Python, and JS generation documented in CHANGELOG
294455a
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Use git --porcelain to check for local changes
60ed995
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
refs #1 - Ensure workspace is clean after Travis build
35869e2 
- Ignore changes in js/ckage-lock.json
- Fix typos leading to not removing js/node_modules
- Ensure c/ is cleaned correctly
- Remove protoc zip file downloaded by ci-script/install-linux.sh
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Ensure make clean deletes intermediate output files
706c39e 
- C  : .i .o .s
- Py : .pyc .pyd .pyo

... reported in https://travis-ci.com/skycoin/hardware-wallet-protob/jobs/181865374#L2279-L2286
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
Merge pull request #4 from simelo/olemis_t1_protob_init
3de9639 
[ci] fixes #1 - Generate protobuffer classes for js, C , and Python
iketheadore pushed a commit that referenced this issue Sep 30, 2019
@olemis
[ci] refs #1 - Delete .d .swp .swo & .orig files in make clean
61c786a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vidya88