Skip to content
GitHub Actions / clippy succeeded Jul 24, 2024 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 150 in src/net/live_fluereflow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

clamp-like pattern without using clamp function

warning: clamp-like pattern without using clamp function
   --> src/net/live_fluereflow.rs:147:36
    |
147 |                       let progress = (last_export_guard.elapsed().as_millis() as f64
    |  ____________________________________^
148 | |                         / interval as f64)
149 | |                         .min(1.0)
150 | |                         .max(0.0);
    | |_________________________________^ help: replace with clamp: `(last_export_guard.elapsed().as_millis() as f64 / interval as f64).clamp(0.0, 1.0)`
    |
    = note: clamp will panic if max < min, min.is_nan(), or max.is_nan()
    = note: clamp returns NaN if the input is NaN
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp
    = note: `#[warn(clippy::manual_clamp)]` on by default

Check warning on line 17 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::tcp::TcpPacket`

warning: unused import: `pnet::packet::tcp::TcpPacket`
  --> src/net/parser/keys.rs:17:5
   |
17 | use pnet::packet::tcp::TcpPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 13 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::icmp::IcmpPacket`

warning: unused import: `pnet::packet::icmp::IcmpPacket`
  --> src/net/parser/keys.rs:13:5
   |
13 | use pnet::packet::icmp::IcmpPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 10 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::dns::DnsPacket`

warning: unused import: `pnet::packet::dns::DnsPacket`
  --> src/net/parser/keys.rs:10:5
   |
10 | use pnet::packet::dns::DnsPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 91 in fluereflow/src/types/fluereflow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (27/7)

warning: this function has too many arguments (27/7)
  --> fluereflow/src/types/fluereflow.rs:63:5
   |
63 | /     pub fn new(
64 | |         source: IpAddr,
65 | |         destination: IpAddr,
66 | |         d_pkts: u32,
...  |
90 | |         tos: u8,
91 | |     ) -> FluereRecord {
   | |_____________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 98 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> fluere-config/src/init.rs:98:5
   |
97 |     let path_config = path_base.join("fluere");
   |     ------------------------------------------- unnecessary `let` binding
98 |     path_config
   |     ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
97 ~     
98 ~     path_base.join("fluere")
   |

Check warning on line 25 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded unit expression

warning: unneeded unit expression
  --> fluere-config/src/init.rs:25:21
   |
25 |                     ()
   |                     ^^ help: remove the final `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
   = note: `#[warn(clippy::unused_unit)]` on by default