Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seasons to method url binding #16

Open
rssawyer23 opened this issue Jul 14, 2023 · 2 comments
Open

Add seasons to method url binding #16

rssawyer23 opened this issue Jul 14, 2023 · 2 comments

Comments

@rssawyer23
Copy link

The _get_seasons appears to be missing from METHOD_URL_BINDING in the client.py file, which prevents the client from being able to hit this API endpoint. I believe the following code should be added to METHOD_URL_BINDING to get this functionality to work:

'_get_seasons': {
        'url': '/api/seasons/',
        'paginated_request': True,
        'docs_url_anchor': '/seasons/seasons_list',
    },
@jpatacz
Copy link
Contributor

jpatacz commented Jul 15, 2023

Hello @rssawyer23!
Thank you for reaching out with this issue.
Yes, this endpoint was not included in the first skillcorner-py client specification. I will consult this issue with our product manager and get back to you with the answer and solution as soon as possible.
Best regards!

@jpatacz
Copy link
Contributor

jpatacz commented Jul 18, 2023

Hello @rssawyer23, I am coming back to you with news concerning the issue.
As we are currently migrating our repository to the gitlab domain and we are introducing some major changes in the core of library we will solve the missing seasons endpoint issue within this migration. I will keep you posted when it is available and ready to use.
Thank you again for your cooperation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants