Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Send render event when component is updated in component library #2021

Merged

Conversation

stasmaxymov
Copy link
Contributor

Description / Motivation

Send a rendered status from a component library handler, when component is re-rendered via component:update command. It provides a feedback to a parent Component library application when component accepted changes and finished rendering.
Extend a status event with rendering uid to enable Component library applications to identify source of messages

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@stasmaxymov stasmaxymov force-pushed the feature/JSS-4869-component-library-render-event branch from 9578d6b to 7e699a7 Compare January 28, 2025 17:44
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I ran unit tests locally and it failed because of unused variable, double check for lint/ts errors

@stasmaxymov
Copy link
Contributor Author

Looks good 👍 I ran unit tests locally and it failed because of unused variable, double check for lint/ts errors

@illiakovalenko I fixed a lint issues and lock file problem

@illiakovalenko illiakovalenko merged commit 92f5707 into release/beta Jan 30, 2025
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-4869-component-library-render-event branch January 30, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants