From 339274152a1f6ecc080e2373d28212b513f0e52b Mon Sep 17 00:00:00 2001 From: Addy Pathania <aditya.pathania22@gmail.com> Date: Fri, 4 Oct 2024 08:55:53 -0400 Subject: [PATCH 1/2] fix default empty image styles --- ...pty-image-field-editing-placeholder.component.ts | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/packages/sitecore-jss-angular/src/components/default-empty-image-field-editing-placeholder.component.ts b/packages/sitecore-jss-angular/src/components/default-empty-image-field-editing-placeholder.component.ts index b06fcec2f6..8473ee59f5 100644 --- a/packages/sitecore-jss-angular/src/components/default-empty-image-field-editing-placeholder.component.ts +++ b/packages/sitecore-jss-angular/src/components/default-empty-image-field-editing-placeholder.component.ts @@ -12,7 +12,16 @@ import { Component } from '@angular/core'; class="scEmptyImage" /> `, - styles: - 'img { min-width:48px; min-height:48px; max-width:400px; max-height:400px; cursor:pointer }', + styles: [ + ` + :host { + min-width: 48px; + min-height: 48px; + max-width: 400px; + max-height: 400px; + cursor: pointer; + } + `, + ], }) export class DefaultEmptyImageFieldEditingComponent {} From 5583c503a3bf2f363c5e9b1c43a2661a656e7e85 Mon Sep 17 00:00:00 2001 From: Addy Pathania <aditya.pathania22@gmail.com> Date: Fri, 4 Oct 2024 08:58:20 -0400 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fd6b8f3b3c..c3f7d891fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,7 @@ Our versioning strategy is as follows: * `[templates/nextjs]` `[templates/react]` `[templates/angular]` `[templates/vue]` Fixed an issue when environment variable is undefined (not present in .env), that produced an "undefined" value in generated config file ([#1875](https://github.com/Sitecore/jss/pull/1875)) * `[templates/nextjs]` Fix embedded personalization not rendering correctly after navigation through router links. ([#1911](https://github.com/Sitecore/jss/pull/1911)) * `[template/angular]` Prevent client-side dictionary API call when SSR data is available ([#1930](https://github.com/Sitecore/jss/pull/1930)) ([#1932](https://github.com/Sitecore/jss/pull/1932)) -* `[sitecore-jss-angular]` Fix default empty field components to not render the unwanted wrapping tags ([#1937](https://github.com/Sitecore/jss/pull/1937)) +* `[sitecore-jss-angular]` Fix default empty field components to not render the unwanted wrapping tags ([#1937](https://github.com/Sitecore/jss/pull/1937)) ([#1940](https://github.com/Sitecore/jss/pull/1940)) ### 🎉 New Features & Improvements