Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[angular-xmcloud] Introduce RowSplitter SXA component #1901

Merged
merged 3 commits into from
Aug 22, 2024
Merged

[angular-xmcloud] Introduce RowSplitter SXA component #1901

merged 3 commits into from
Aug 22, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Aug 22, 2024 •
edited
Loading

Description / Motivation

Adds RowSplitter SXA component

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate) - HTML matches the XMCloud preview

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team August 22, 2024 12:42
@art-alexeyenko art-alexeyenko changed the title [angular-xmcloud] Introduce RowSplitter [angular-xmcloud] Introduce RowSplitter SXA component Aug 22, 2024
addy-pathania
addy-pathania approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍🏼

@art-alexeyenko art-alexeyenko merged commit e00cdb0 into dev Aug 22, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-3562-rowsplitter branch August 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art-alexeyenko @addy-pathania