[sitecore-jss-nextjs] fix for Redirects related to x-middleware-next Header #SXA-6564 #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKechashin
approved these changes
Aug 22, 2024
illiakovalenko
requested changes
Aug 22, 2024
packages/sitecore-jss-nextjs/src/middleware/redirects-middleware.ts
Outdated
Show resolved
Hide resolved
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-6564-netlify-redirects
branch
from
8b4508e to
80f98a3
Compare
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-6564-netlify-redirects
branch
from
80f98a3 to
e2e8332
Compare
illiakovalenko
approved these changes
Aug 29, 2024
sc-ruslanmatkovskyi
changed the title
sc-ruslanmatkovskyi
force-pushed
the
bugfix/SXA-6564-netlify-redirects
branch
from
762cc66 to
9622d4b
Compare
illiakovalenko
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
The issue was caused by the x-middleware-next header in Next.js, which prevented the flow from being interrupted properly.
As a result, redirects did not function correctly in certain cases.
This fix ensures that the flow is correctly interrupted, allowing redirects to work as expected.
Testing Details
Types of changes