Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-nextjs] Clear preview Data cookies #1878

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

addy-pathania
Copy link
Contributor

@addy-pathania addy-pathania commented Aug 8, 2024

Description / Motivation

To ensure switching between pages works seamlessly we need to clear the the preview data from previous route because in some instances it sets duplicate cookie values which causes the page-not-found error.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@addy-pathania addy-pathania added the do-not-review PR's not ready for review label Aug 8, 2024
@addy-pathania addy-pathania removed the do-not-review PR's not ready for review label Aug 8, 2024
@addy-pathania addy-pathania requested a review from a team August 8, 2024 04:18
@addy-pathania addy-pathania changed the title [sitecore-jss-nextjs] Increase preview data cache time [sitecore-jss-nextjs] Clear preview Data cookies Aug 8, 2024
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (pending unit tests)

@addy-pathania addy-pathania merged commit a230712 into dev Aug 8, 2024
1 check passed
@addy-pathania addy-pathania deleted the bugfix/jss-3818-page-switch branch August 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants