Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next.js] [Editing Integration] Secure hosting updates #1832

Merged
merged 2 commits into from
Jun 26, 2024
Merged

[Next.js] [Editing Integration] Secure hosting updates #1832

merged 2 commits into from
Jun 26, 2024

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

Updates to Next.js editing integration to further support secure hosting scenarios (on XM Cloud & Vercel), including:

  • Added header pass-through capability to the editing handler SSR request (chromes edit mode). Headers which will be passed: authorization, cookie
  • Removed experimental x-sitecore-protection-bypass query param propagation
  • Added support for x-vercel-set-bypass-cookie query param propagation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ambrauer added 2 commits June 21, 2024 15:09
@ambrauer
* add header pass-through capability to Editing Chromes handler SSR r…
adb70f4 
…equest

* removed experimental `x-sitecore-protection-bypass` query param propagation
* added `x-vercel-set-bypass-cookie` query param propagation
@ambrauer
CHANGELOG entry
7b646c2
@ambrauer ambrauer requested a review from a team June 26, 2024 15:39
art-alexeyenko
art-alexeyenko approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid piece of work 👍

addy-pathania
addy-pathania approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏼

@ambrauer ambrauer merged commit cea6da5 into dev Jun 26, 2024
1 check passed
@ambrauer ambrauer deleted the feature/jss-3476-rh-security branch June 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ambrauer @art-alexeyenko @addy-pathania